ReferenceUsedNamesOnlySniff: fixed fixer for reference via FQN without namespace in doccomment

Author: kukulich

SlevomatCodingStandard/Sniffs/Namespaces/ReferenceUsedNamesOnlySniff.php

@@ -271,7 +271,17 @@ public function process(\PHP_CodeSniffer\Files\File $phpcsFile, $openTagPointer)
 						), $startPointer, self::CODE_REFERENCE_VIA_FULLY_QUALIFIED_NAME_WITHOUT_NAMESPACE);
 						if ($fix) {
 							$phpcsFile->fixer->beginChangeset();
-							$phpcsFile->fixer->replaceToken($startPointer, substr($tokens[$startPointer]['content'], 1));
+
+							if ($reference->fromDocComment) {
+								$fixedDocComment = preg_replace_callback('~(\\s|\|)(' . preg_quote($name, '~') . ')(\\s|\||\[|$)~', function (array $matches): string {
+									return $matches[1] . ltrim($matches[2], '\\\\') . $matches[3];
+								}, $tokens[$startPointer]['content']);
+
+								$phpcsFile->fixer->replaceToken($startPointer, $fixedDocComment);
+							} else {
+								$phpcsFile->fixer->replaceToken($startPointer, substr($tokens[$startPointer]['content'], 1));
+							}
+
 							$phpcsFile->fixer->endChangeset();
 						}
 					} else {

tests/Sniffs/Namespaces/ReferenceUsedNamesOnlySniffTest.php

@@ -682,6 +682,7 @@ public function testFixableReferenceViaFullyQualifiedNameWithoutNamespace(): voi
 			'specialExceptionNames' => [
 				'BarErrorX',
 			],
+			'searchAnnotations' => true,
 		], [ReferenceUsedNamesOnlySniff::CODE_REFERENCE_VIA_FULLY_QUALIFIED_NAME_WITHOUT_NAMESPACE]);
 		self::assertAllFixedInFile($report);
 	}

tests/Sniffs/Namespaces/data/fixableReferenceViaFullyQualifiedNameWithoutNamespace.fixed.php

@@ -1,5 +1,9 @@
 <?php
 
+/**
+ * @param \Some\Exception $e
+ * @throws \Exception
+ */
 function bar(\Some\Exception $e)
 {
 	try {
@@ -13,7 +17,7 @@ function bar(\Some\Exception $e)
 	} catch (TypeError $ex) {
 
 	} catch (BarErrorX $ex) {
-
+		throw new Exception();
 	}
 }
 

tests/Sniffs/Namespaces/data/fixableReferenceViaFullyQualifiedNameWithoutNamespace.php

@@ -1,5 +1,9 @@
 <?php
 
+/**
+ * @param \Some\Exception $e
+ * @throws \Exception
+ */
 function bar(\Some\Exception $e)
 {
 	try {
@@ -13,7 +17,7 @@ function bar(\Some\Exception $e)
 	} catch (\TypeError $ex) {
 
 	} catch (\BarErrorX $ex) {
-
+		throw new \Exception();
 	}
 }