UselessParenthesesSniff: Fixed false positive

kukulich · kukulich · commit 2c0ecbcdbc2c · 2019-03-11T16:58:05.000+01:00
diff --git a/SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php b/SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php
@@ -57,6 +57,7 @@
 use const T_USE;
 use const T_VARIABLE;
 use const T_WHITESPACE;
+use const T_YIELD_FROM;
 
 class UselessParenthesesSniff implements Sniff
 {
@@ -123,7 +124,7 @@ public function process(File $phpcsFile, $parenthesisOpenerPointer): void
 
 		/** @var int $pointerAfterParenthesisOpener */
 		$pointerAfterParenthesisOpener = TokenHelper::findNextEffective($phpcsFile, $parenthesisOpenerPointer + 1);
-		if (in_array($tokens[$pointerAfterParenthesisOpener]['code'], [T_NEW, T_CLONE], true)) {
+		if (in_array($tokens[$pointerAfterParenthesisOpener]['code'], [T_NEW, T_CLONE, T_YIELD_FROM], true)) {
 			return;
 		}
 
diff --git a/tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php b/tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php
@@ -119,6 +119,8 @@ function () {
     'a',
 ] + $defaults('b'));
 
+$y = (yield from whatever()) ?? $y;
+
 // Must be last
 return true
     ? 100

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,7 @@`
`57`	`57`	`use const T_USE;`
`58`	`58`	`use const T_VARIABLE;`
`59`	`59`	`use const T_WHITESPACE;`
	`60`	`+use const T_YIELD_FROM;`
`60`	`61`
`61`	`62`	`class UselessParenthesesSniff implements Sniff`
`62`	`63`	`{`
`@@ -123,7 +124,7 @@ public function process(File $phpcsFile, $parenthesisOpenerPointer): void`
`123`	`124`
`124`	`125`	`/** @var int $pointerAfterParenthesisOpener */`
`125`	`126`	`$pointerAfterParenthesisOpener = TokenHelper::findNextEffective($phpcsFile, $parenthesisOpenerPointer + 1);`
`126`		`- if (in_array($tokens[$pointerAfterParenthesisOpener]['code'], [T_NEW, T_CLONE], true)) {`
	`127`	`+ if (in_array($tokens[$pointerAfterParenthesisOpener]['code'], [T_NEW, T_CLONE, T_YIELD_FROM], true)) {`
`127`	`128`	`return;`
`128`	`129`	`}`
`129`	`130`