UnusedUsesSniff: fixed false positives

Author: kukulich

SlevomatCodingStandard/Sniffs/Namespaces/UnusedUsesSniff.php

@@ -163,7 +163,7 @@ public function process(\PHP_CodeSniffer\Files\File $phpcsFile, $openTagPointer)
 
 							if (
 								!preg_match('~(?<=^|[^a-z\\\\])(' . preg_quote($nameAsReferencedInFile, '~') . ')(?=::)~i', $annotation->getParameters(), $matches)
-								&& !preg_match('~(?<=@)(' . preg_quote($nameAsReferencedInFile, '~') . ')(?=\\\\|\()~i', $annotation->getParameters(), $matches)
+								&& !preg_match('~(?<=@)(' . preg_quote($nameAsReferencedInFile, '~') . ')(?=[^\\w])~i', $annotation->getParameters(), $matches)
 							) {
 								continue;
 							}

tests/Sniffs/Namespaces/UnusedUsesSniffTest.php

@@ -108,7 +108,7 @@ public function testUsedUseInAnnotationWithDisabledSearchAnnotations(): void
 			'searchAnnotations' => false,
 		]);
 
-		self::assertSame(32, $report->getErrorCount());
+		self::assertSame(36, $report->getErrorCount());
 
 		self::assertSniffError($report, 5, UnusedUsesSniff::CODE_UNUSED_USE, 'Type Assert is not used in this file.');
 		self::assertSniffError($report, 6, UnusedUsesSniff::CODE_UNUSED_USE, 'Type Doctrine\ORM\Mapping (as ORM) is not used in this file.');
@@ -141,6 +141,10 @@ public function testUsedUseInAnnotationWithDisabledSearchAnnotations(): void
 		self::assertSniffError($report, 34, UnusedUsesSniff::CODE_UNUSED_USE, 'Type MethodParameter4 is not used in this file.');
 		self::assertSniffError($report, 35, UnusedUsesSniff::CODE_UNUSED_USE, 'Type Discriminator\Lorem is not used in this file.');
 		self::assertSniffError($report, 36, UnusedUsesSniff::CODE_UNUSED_USE, 'Type Discriminator\Ipsum is not used in this file.');
+		self::assertSniffError($report, 37, UnusedUsesSniff::CODE_UNUSED_USE, 'Type Outer is not used in this file.');
+		self::assertSniffError($report, 38, UnusedUsesSniff::CODE_UNUSED_USE, 'Type Inner1 is not used in this file.');
+		self::assertSniffError($report, 39, UnusedUsesSniff::CODE_UNUSED_USE, 'Type Inner2 is not used in this file.');
+		self::assertSniffError($report, 40, UnusedUsesSniff::CODE_UNUSED_USE, 'Type Inner3 is not used in this file.');
 	}
 
 	public function testUsedUseInAnnotationWithEnabledSearchAnnotations(): void

tests/Sniffs/Namespaces/data/unusedUsesInAnnotation.php

@@ -34,6 +34,10 @@
 use MethodParameter4;
 use Discriminator\Lorem;
 use Discriminator\Ipsum;
+use Outer;
+use Inner1;
+use Inner2;
+use Inner3;
 
 /**
  * @ORM\Entity()
@@ -98,6 +102,14 @@ public function test()
  * @CustomAnnotation(prop=@AnotherCustomAnnotation(D::class))
  */
 
+/**
+ * @Outer({
+ *     @Inner1(type="string"),
+ *     @Inner2,
+ *     @Inner3(),
+ * })
+ */
+
 /** @var $variable UglyInlineAnnotation */
 
 /**