Static analysis with PHPStan

Author: ondrejmirtes

.travis.yml

@@ -5,7 +5,7 @@ php:
 before_script:
   - composer self-update
 script:
-  - composer install
+  - composer install --ignore-platform-reqs
   - vendor/bin/phing
 after_script:
   - php vendor/bin/coveralls -v

SlevomatCodingStandard/Sniffs/Namespaces/AlphabeticallySortedUsesSniff.php

@@ -99,7 +99,8 @@ private function fixAlphabeticalOrder(
 	 */
 	private function compareStrings($a, $b)
 	{
-		for ($i = 0; $i < min(strlen($a), strlen($b)); $i++) {
+		$i = 0;
+		for (; $i < min(strlen($a), strlen($b)); $i++) {
 			if ($this->isSpecialCharacter($a[$i]) && !$this->isSpecialCharacter($b[$i])) {
 				return -1;
 			} elseif (!$this->isSpecialCharacter($a[$i]) && $this->isSpecialCharacter($b[$i])) {

build.xml

@@ -5,7 +5,8 @@
 		composer,
 		lint,
 		cs,
-		tests
+		tests,
+		phpstan
 	"/>
 
 	<target name="composer">
@@ -16,6 +17,7 @@
 			checkreturn="true"
 		>
 			<arg value="install"/>
+			<arg value="--ignore-platform-reqs"/>
 		</exec>
 	</target>
 
@@ -81,4 +83,28 @@
 		</exec>
 	</target>
 
+	<target name="phpstan">
+		<php expression="PHP_VERSION_ID >= 70000 ?'true':'false'" returnProperty="isPHP7" level="verbose" />
+		<if>
+			<equals arg1="${isPHP7}" arg2="true" />
+			<then>
+				<exec
+					executable="vendor/bin/phpstan"
+					logoutput="true"
+					passthru="true"
+					checkreturn="true"
+				>
+					<arg value="analyse"/>
+					<arg value="-c"/>
+					<arg path="phpstan.neon"/>
+					<arg path="SlevomatCodingStandard"/>
+					<arg path="tests"/>
+				</exec>
+			</then>
+			<else>
+				<echo message="PHPStan requires PHP 7." />
+			</else>
+		</if>
+	</target>
+
 </project>

composer.json

@@ -12,6 +12,7 @@
 	"require-dev": {
 		"consistence/coding-standard": "^0.10",
 		"phing/phing": "^2.9",
+		"phpstan/phpstan": "dev-dev#1cb3904e17",
 		"phpunit/phpunit": "^5.0",
 		"satooshi/php-coveralls": "dev-master"
 	},

phpstan.neon

@@ -0,0 +1,3 @@
+parameters:
+	excludes_analyse:
+		- */tests/*/data/*