ReferencedNameHelper: Fixed detection

Author: kukulich

SlevomatCodingStandard/Helpers/ReferencedNameHelper.php

@@ -270,8 +270,13 @@ private static function isReferencedName(File $phpcsFile, int $startPointer): bo
 			if ($constPointer !== null && TokenHelper::findNext($phpcsFile, [T_OPEN_SHORT_ARRAY, T_ARRAY], $constPointer + 1, $startPointer) === null) {
 				return false;
 			}
-		} elseif ($previousToken['code'] === T_BITWISE_AND && TokenHelper::findPreviousLocal($phpcsFile, [T_FUNCTION], $previousPointer - 1) !== null) {
-			return false;
+		} elseif ($previousToken['code'] === T_BITWISE_AND) {
+			$pointerBefore = TokenHelper::findPreviousEffective($phpcsFile, $previousPointer - 1);
+			$isFunctionPointerBefore = TokenHelper::findPreviousLocal($phpcsFile, T_FUNCTION, $previousPointer - 1) !== null;
+
+			if ($tokens[$pointerBefore]['code'] !== T_VARIABLE && $isFunctionPointerBefore) {
+				return false;
+			}
 		} elseif ($previousToken['code'] === T_GOTO) {
 			return false;
 		}

tests/Helpers/ReferencedNameHelperTest.php

@@ -52,6 +52,8 @@ public function testGetAllReferencedNames(): void
 			['OPENSSL_ALGO_SHA512', false, true],
 			['SomeTrait', false, false],
 			['string', true, false],
+			['doSomething', true, false],
+			['STREAM_URL_STAT_QUIET', false, true],
 		];
 
 		$names = ReferencedNameHelper::getAllReferencedNames($phpcsFile, 0);

tests/Helpers/data/lotsOfReferencedNames.php

@@ -5,6 +5,9 @@
 use Doctrine\ORM\Mapping as ORM;
 use UsedNamespace\UsedNameFooBar as UsedNameFooBarBaz;
 use function DI\string;
+use function doSomething;
+use function stream_wrapper_restore;
+use const STREAM_URL_STAT_QUIET;
 
 class FooClass extends \ExtendedClass implements \ImplementedInterface, \SecondImplementedInterface, \ThirdImplementedInterface
 {
@@ -110,3 +113,14 @@ class OpenSsl
 };
 
 string();
+
+function whatever($flags)
+{
+	foreach ([] as $item) {
+		doSomething($item);
+	}
+
+	if ($flags & STREAM_URL_STAT_QUIET) {
+
+	}
+}