SlevomatCodingStandard.ControlStructures.NewWithParentheses: Fixed false positive

Author: kukulich

SlevomatCodingStandard/Sniffs/ControlStructures/NewWithParenthesesSniff.php

@@ -48,6 +48,10 @@ public function process(File $phpcsFile, $newPointer): void
 			return;
 		}
 
+		if ($tokens[$nextPointer]['code'] === T_OPEN_PARENTHESIS) {
+			$nextPointer = $tokens[$nextPointer]['parenthesis_closer'];
+		}
+
 		$shouldBeOpenParenthesisPointer = $nextPointer + 1;
 		do {
 			$shouldBeOpenParenthesisPointer = TokenHelper::findNext(

tests/Sniffs/ControlStructures/NewWithParenthesesSniffTest.php

@@ -17,9 +17,9 @@ public function testErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/newWithParenthesesErrors.php', [], [NewWithParenthesesSniff::CODE_MISSING_PARENTHESES]);
 
-		self::assertSame(19, $report->getErrorCount());
+		self::assertSame(20, $report->getErrorCount());
 
-		foreach ([3, 9, 17, 22, 25, 29, 35, 37, 40, 43, 45, 47, 48, 50, 52, 57] as $line) {
+		foreach ([3, 9, 17, 22, 25, 29, 35, 37, 40, 43, 45, 47, 48, 50, 52, 57, 60] as $line) {
 			self::assertSniffError($report, $line, NewWithParenthesesSniff::CODE_MISSING_PARENTHESES);
 		}
 

tests/Sniffs/ControlStructures/data/newWithParenthesesErrors.fixed.php

@@ -56,3 +56,5 @@ public static function getInstance()
 $aaa = [
 	(string) new stdClass() => new stdClass()
 ];
+
+$aaaa = new (stdClass::class)();

tests/Sniffs/ControlStructures/data/newWithParenthesesErrors.php

@@ -56,3 +56,5 @@ public static function getInstance()
 $aaa = [
 	(string) new stdClass => new stdClass
 ];
+
+$aaaa = new (stdClass::class);

tests/Sniffs/ControlStructures/data/newWithParenthesesNoErrors.php

@@ -56,3 +56,5 @@ public static function getInstance()
 $aaa = [
 	(string) new stdClass() => new stdClass()
 ];
+
+$aaaa = new (stdClass::class)();