Skip to content

Commit 67b779b

Browse files
grongorkukulich
authored andcommitted
Fix RequireSingleLineMethodSignature for semicolons
1 parent 43a2d40 commit 67b779b

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

SlevomatCodingStandard/Sniffs/Classes/AbstractMethodSignature.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ protected function getSignatureStartAndEndPointers(File $phpcsFile, int $methodP
4646
assert(!is_bool($signatureStartPointer));
4747

4848
$pointerAfterSignatureEnd = TokenHelper::findNext($phpcsFile, [T_OPEN_CURLY_BRACKET, T_SEMICOLON], $methodPointer + 1);
49+
if ($phpcsFile->getTokens()[$pointerAfterSignatureEnd]['code'] === T_SEMICOLON) {
50+
return [$signatureStartPointer, $pointerAfterSignatureEnd];
51+
}
4952

5053
$signatureEndPointer = TokenHelper::findPreviousEffective($phpcsFile, $pointerAfterSignatureEnd - 1);
5154
assert(is_int($signatureEndPointer));

tests/Sniffs/Classes/data/requireSingleLineMethodSignatureNoErrors.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function multiLineWithNoReturnType(
4545
);
4646

4747
public function multiLineMethodWithPrecisely121CharsOnSingleline(
48-
$someHugeVariableNameJustToFillTheSpaceBlaah
48+
$someHugeVariableNameJustToFillTheSpaceBlah
4949
) : void;
5050
}
5151

0 commit comments

Comments
 (0)