ReturnTypeHint: report missing type hint in abstract methods

Author: vrana

SlevomatCodingStandard/Sniffs/TypeHints/ReturnTypeHintSniff.php

@@ -205,7 +205,7 @@ private function checkFunctionTypeHint(
 			? ($hasReturnAnnotation && !$isAnnotationReturnTypeVoidOrNever)
 			: FunctionHelper::returnsValue($phpcsFile, $functionPointer);
 
-		if ($returnsValue && !$hasReturnAnnotation) {
+		if (($returnsValue || $isAbstract) && !$hasReturnAnnotation) {
 			if (count($prefixedReturnAnnotations) !== 0) {
 				$this->reportUselessSuppress($phpcsFile, $functionPointer, $isSuppressedAnyTypeHint, $suppressNameAnyTypeHint);
 				return;

tests/Sniffs/TypeHints/ReturnTypeHintSniffTest.php

@@ -33,7 +33,7 @@ public function testErrors(): void
 			'traversableTypeHints' => ['Traversable', '\ArrayIterator'],
 		]);
 
-		self::assertSame(65, $report->getErrorCount());
+		self::assertSame(67, $report->getErrorCount());
 
 		self::assertSniffError($report, 6, ReturnTypeHintSniff::CODE_MISSING_ANY_TYPE_HINT);
 		self::assertSniffError($report, 14, ReturnTypeHintSniff::CODE_MISSING_NATIVE_TYPE_HINT);
@@ -108,6 +108,9 @@ public function testErrors(): void
 		self::assertSniffError($report, 383, ReturnTypeHintSniff::CODE_MISSING_NATIVE_TYPE_HINT);
 		self::assertSniffError($report, 388, ReturnTypeHintSniff::CODE_MISSING_NATIVE_TYPE_HINT);
 
+		self::assertSniffError($report, 392, ReturnTypeHintSniff::CODE_MISSING_ANY_TYPE_HINT);
+		self::assertSniffError($report, 397, ReturnTypeHintSniff::CODE_MISSING_ANY_TYPE_HINT);
+
 		self::assertAllFixedInFile($report);
 	}
 

tests/Sniffs/TypeHints/data/returnTypeHintErrors.fixed.php

@@ -376,4 +376,10 @@ public function returnNonEmptyArray(): array
 	{
 	}
 
+	abstract public function returnWhoKnows();
+
+}
+
+interface Whateverable {
+	function returnWhoKnows();
 }

tests/Sniffs/TypeHints/data/returnTypeHintErrors.php

@@ -389,4 +389,10 @@ public function returnNonEmptyArray()
 	{
 	}
 
+	abstract public function returnWhoKnows();
+
+}
+
+interface Whateverable {
+	function returnWhoKnows();
 }