RequireNullCoalesceOperatorSniff: Fixed false positive

Author: kukulich

SlevomatCodingStandard/Sniffs/ControlStructures/RequireNullCoalesceOperatorSniff.php

@@ -4,6 +4,7 @@
 
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Sniffs\Sniff;
+use PHP_CodeSniffer\Util\Tokens;
 use SlevomatCodingStandard\Helpers\IdentificatorHelper;
 use SlevomatCodingStandard\Helpers\TokenHelper;
 use const T_BOOLEAN_NOT;
@@ -136,6 +137,12 @@ public function checkIdenticalOperator(File $phpcsFile, int $identicalOperator):
 			return;
 		}
 
+		$pointerBeforeCondition = TokenHelper::findPreviousEffective($phpcsFile, ($isYodaCondition ? $pointerBeforeIdenticalOperator : $variableStartPointer) - 1);
+
+		if (in_array($tokens[$pointerBeforeCondition]['code'], Tokens::$booleanOperators, true)) {
+			return;
+		}
+
 		/** @var int $inlineThenPointer */
 		$inlineThenPointer = TokenHelper::findNextEffective($phpcsFile, ($isYodaCondition ? $variableEndPointer : $pointerAfterIdenticalOperator) + 1);
 		if ($tokens[$inlineThenPointer]['code'] !== T_INLINE_THEN) {

tests/Sniffs/ControlStructures/data/requireNullCoalesceOperatorNoErrors.php

@@ -35,3 +35,7 @@
 $o = $oo !== null ? $oo->property : null;
 
 $p = $pp === null ? null : $pp + 1;
+
+$q = $r !== null && $s !== null
+	? $s
+	: '';