EarlyExitSniff: Improved internal errors reporting

Author: kukulich

SlevomatCodingStandard/Sniffs/ControlStructures/EarlyExitSniff.php

@@ -382,6 +382,11 @@ private function getAllConditionsPointers(File $phpcsFile, int $conditionPointer
 			if ($currentConditionPointer !== null) {
 				while (in_array($tokens[$currentConditionPointer]['code'], [T_ELSEIF, T_ELSE], true)) {
 					$conditionsPointers[] = $currentConditionPointer;
+
+					if (!array_key_exists('scope_closer', $tokens[$currentConditionPointer])) {
+						throw new Exception(sprintf('"%s" without curly braces is not supported.', $tokens[$currentConditionPointer]['content']));
+					}
+
 					$currentConditionPointer = TokenHelper::findNextEffective($phpcsFile, $tokens[$currentConditionPointer]['scope_closer'] + 1);
 				}
 			}

tests/Sniffs/ControlStructures/EarlyExitSniffTest.php

@@ -53,6 +53,13 @@ public function testElseifWithoutCurlyBraces(): void
 		self::checkFile(__DIR__ . '/data/earlyExitElseifWithoutCurlyBraces.php', [], [EarlyExitSniff::CODE_USELESS_ELSEIF]);
 	}
 
+	public function testElseifWithSpace(): void
+	{
+		self::expectException(Throwable::class);
+		self::expectExceptionMessage('"else" without curly braces is not supported.');
+		self::checkFile(__DIR__ . '/data/earlyExitElseifWithSpace.php', [], [EarlyExitSniff::CODE_USELESS_ELSEIF]);
+	}
+
 	public function testElseWithoutCurlyBraces(): void
 	{
 		self::expectException(Throwable::class);

tests/Sniffs/ControlStructures/data/earlyExitElseifWithSpace.php

@@ -0,0 +1,11 @@
+<?php
+
+function ($a) {
+	if (true) {
+		return false;
+	} elseif ($a) {
+		return false;
+	} else if (false) {
+		return false;
+	}
+};