ReferenceUsedNamesOnlySniff: Fixed false positives

Author: kukulich

SlevomatCodingStandard/Sniffs/Namespaces/ReferenceUsedNamesOnlySniff.php

@@ -246,8 +246,15 @@ public function process(File $phpcsFile, $openTagPointer): void
 				&& !NamespaceHelper::hasNamespace($name)
 				&& NamespaceHelper::findCurrentNamespaceName($phpcsFile, $startPointer) !== null
 				&& !array_key_exists(UseStatement::getUniqueId($reference->type, $name), $useStatements);
-			$isGlobalFunctionFallback = $reference->isFunction && $isGlobalFallback;
-			$isGlobalConstantFallback = $reference->isConstant && $isGlobalFallback;
+
+			$isGlobalFunctionFallback = false;
+			if ($reference->isFunction && $isGlobalFallback) {
+				$isGlobalFunctionFallback = !array_key_exists(strtolower($reference->name), $definedFunctionsIndex);
+			}
+			$isGlobalConstantFallback = false;
+			if ($reference->isConstant && $isGlobalFallback) {
+				$isGlobalConstantFallback = !array_key_exists($reference->name, $definedConstantsIndex);
+			}
 
 			if ($isFullyQualified) {
 				if ($reference->isClass && $this->allowFullyQualifiedNameForCollidingClasses) {

tests/Sniffs/Namespaces/ReferenceUsedNamesOnlySniffTest.php

@@ -115,6 +115,14 @@ public function testReferencingGlobalFunctionViaFallback(): void
 		);
 	}
 
+	public function testReferencingDefinedFunction(): void
+	{
+		$report = self::checkFile(__DIR__ . '/data/referencingDefinedFunction.php', [
+			'allowFallbackGlobalFunctions' => false,
+		]);
+		self::assertNoSniffErrorInFile($report);
+	}
+
 	public function testReferencingGlobalConstantViaFallback(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/shouldBeInUseStatement.php', [
@@ -128,6 +136,14 @@ public function testReferencingGlobalConstantViaFallback(): void
 		);
 	}
 
+	public function testReferencingDefinedConstant(): void
+	{
+		$report = self::checkFile(__DIR__ . '/data/referencingDefinedConstant.php', [
+			'allowFallbackGlobalConstants' => false,
+		]);
+		self::assertNoSniffErrorInFile($report);
+	}
+
 	/**
 	 * @dataProvider dataIgnoredNamesForIrrelevantTests
 	 * @param string[] $ignoredNames

tests/Sniffs/Namespaces/data/referencingDefinedConstant.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace Whatever;
+
+const HELLO = 'world';
+
+echo HELLO;

tests/Sniffs/Namespaces/data/referencingDefinedFunction.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Whatever;
+
+function hello()
+{
+	return 'world';
+}
+
+echo hello();