Added UselessVariableSniff to phpcs.xml

kukulich · kukulich · commit 8053559a8172 · 2018-08-25T00:55:34.000+02:00
diff --git a/SlevomatCodingStandard/Sniffs/ControlStructures/EarlyExitSniff.php b/SlevomatCodingStandard/Sniffs/ControlStructures/EarlyExitSniff.php
@@ -461,9 +461,7 @@ private function getNegativeLogicalCondition(File $phpcsFile, int $conditionBoun
 
 		} while (true);
 
-		$negativeCondition .= $this->getNegativeCondition($phpcsFile, $nestedConditionStartPointer, $conditionBoundaryEndPointer, true);
-
-		return $negativeCondition;
+		return $negativeCondition . $this->getNegativeCondition($phpcsFile, $nestedConditionStartPointer, $conditionBoundaryEndPointer, true);
 	}
 
 	private function getNegativeCondition(File $phpcsFile, int $conditionBoundaryStartPointer, int $conditionBoundaryEndPointer, bool $nested = false): string
diff --git a/build/phpcs.xml b/build/phpcs.xml
@@ -93,4 +93,5 @@
 	<rule ref="SlevomatCodingStandard.TypeHints.NullTypeHintOnLastPosition"/>
 	<rule ref="SlevomatCodingStandard.TypeHints.UselessConstantTypeHint"/>
 	<rule ref="SlevomatCodingStandard.Variables.UnusedVariable"/>
+	<rule ref="SlevomatCodingStandard.Variables.UselessVariable"/>
 </ruleset>

Original file line number	Diff line number	Diff line change
`@@ -461,9 +461,7 @@ private function getNegativeLogicalCondition(File $phpcsFile, int $conditionBoun`
`461`	`461`
`462`	`462`	`} while (true);`
`463`	`463`
`464`		`- $negativeCondition .= $this->getNegativeCondition($phpcsFile, $nestedConditionStartPointer, $conditionBoundaryEndPointer, true);`
`465`		`-`
`466`		`- return $negativeCondition;`
	`464`	`+ return $negativeCondition . $this->getNegativeCondition($phpcsFile, $nestedConditionStartPointer, $conditionBoundaryEndPointer, true);`
`467`	`465`	`}`
`468`	`466`
`469`	`467`	`private function getNegativeCondition(File $phpcsFile, int $conditionBoundaryStartPointer, int $conditionBoundaryEndPointer, bool $nested = false): string`