Make fixability of DisallowShortTernaryOperator configurable

Author: Majkl578

README.md

@@ -179,6 +179,10 @@ Requires `new` with parentheses.
 
 Disallows short ternary operator `?:`.
 
+Sniff provides the following settings:
+
+* `fixable`: the sniff is fixable by default, however in strict code it makes sense to forbid this weakly typed form of ternary altogether, you can disable fixability with this option.
+
 #### SlevomatCodingStandard.ControlStructures.RequireShortTernaryOperator 🔧
 
 Requires short ternary operator `?:` when possible.

SlevomatCodingStandard/Sniffs/ControlStructures/DisallowShortTernaryOperatorSniff.php

@@ -9,6 +9,9 @@ class DisallowShortTernaryOperatorSniff implements \PHP_CodeSniffer\Sniffs\Sniff
 
 	public const CODE_DISALLOWED_SHORT_TERNARY_OPERATOR = 'DisallowedShortTernaryOperator';
 
+	/** @var bool */
+	public $fixable = true;
+
 	/**
 	 * @return mixed[]
 	 */
@@ -43,6 +46,11 @@ public function process(\PHP_CodeSniffer\Files\File $phpcsFile, $inlineThenPoint
 			return;
 		}
 
+		if (!$this->fixable) {
+			$phpcsFile->addError($message, $inlineThenPointer, self::CODE_DISALLOWED_SHORT_TERNARY_OPERATOR);
+			return;
+		}
+
 		$fix = $phpcsFile->addFixableError($message, $inlineThenPointer, self::CODE_DISALLOWED_SHORT_TERNARY_OPERATOR);
 
 		if (!$fix) {

tests/Sniffs/ControlStructures/DisallowShortTernaryOperatorSniffTest.php

@@ -23,4 +23,17 @@ public function testErrors(): void
 		$this->assertAllFixedInFile($report);
 	}
 
+	public function testFixableDisabled(): void
+	{
+		$report = self::checkFile(__DIR__ . '/data/disallowShortTernaryOperatorErrorsFixableDisabled.php', ['fixable' => false]);
+
+		self::assertSame(3, $report->getErrorCount());
+
+		self::assertSniffError($report, 3, DisallowShortTernaryOperatorSniff::CODE_DISALLOWED_SHORT_TERNARY_OPERATOR);
+		self::assertSniffError($report, 5, DisallowShortTernaryOperatorSniff::CODE_DISALLOWED_SHORT_TERNARY_OPERATOR);
+		self::assertSniffError($report, 7, DisallowShortTernaryOperatorSniff::CODE_DISALLOWED_SHORT_TERNARY_OPERATOR);
+
+		$this->assertAllFixedInFile($report);
+	}
+
 }

tests/Sniffs/ControlStructures/data/disallowShortTernaryOperatorErrorsFixableDisabled.fixed.php

@@ -0,0 +1,7 @@
+<?php
+
+$x = $a ?: true;
+
+sprintf('%s', $x ?: 'string');
+
+$z = isset($x) ?: false;

tests/Sniffs/ControlStructures/data/disallowShortTernaryOperatorErrorsFixableDisabled.php

@@ -0,0 +1,7 @@
+<?php
+
+$x = $a ?: true;
+
+sprintf('%s', $x ?: 'string');
+
+$z = isset($x) ?: false;