SlevomatCodingStandard.PHP.OptimizedFunctionsWithoutUnpacking: Fixed false positive with first class callable

Author: kukulich

SlevomatCodingStandard/Sniffs/PHP/OptimizedFunctionsWithoutUnpackingSniff.php

@@ -99,6 +99,11 @@ public function process(File $phpcsFile, $pointer): void
 			return;
 		}
 
+		if (TokenHelper::findNextEffective($phpcsFile, $nextTokenAfterSeparatorPointer + 1) === $closeBracketPointer) {
+			// First class callables
+			return;
+		}
+
 		$phpcsFile->addError(
 			sprintf('Function %s is specialized by PHP and should not use argument unpacking.', $invokedName),
 			$nextTokenAfterSeparatorPointer,

tests/Sniffs/PHP/data/optimizedFunctionsWithoutUnpackingNamespacedNoErrors.php

@@ -1,7 +1,8 @@
-<?php
+<?php // lint >= 8.1
 
 namespace Test;
 
+use function array_map;
 use function func_get_args;
 use function is_double as is_funny;
 use function strlen;
@@ -29,3 +30,5 @@
 new Foo(...bar());
 
 $foo->strlen(...$foo);
+
+array_map(\intval(...), ['123', '23']);

tests/Sniffs/PHP/data/optimizedFunctionsWithoutUnpackingNotNamespacedNoErrors.php

@@ -1,4 +1,4 @@
-<?php
+<?php // lint >= 8.1
 
 if (0) {
 	function strlen(...$foo)
@@ -9,3 +9,5 @@ function strlen(...$foo)
 strlen($foo);
 new Foo(...$foo);
 (function (...$foo) {})(...$foo);
+
+array_map(intval(...), ['123', '23']);