SlevomatCodingStandard.Namespaces.UnusedUses: Fixed false positive thanks to PHPCS upgrade

kukulich · kukulich · commit 923e12170e92 · 2024-03-09T13:57:37.000+01:00
diff --git a/composer.json b/composer.json
@@ -19,7 +19,7 @@
 		"php": "^7.2 || ^8.0",
 		"dealerdirect/phpcodesniffer-composer-installer": "^0.6.2 || ^0.7 || ^1.0",
 		"phpstan/phpdoc-parser": "^1.23.1",
-		"squizlabs/php_codesniffer": "^3.7.1"
+		"squizlabs/php_codesniffer": "^3.9.0"
 	},
 	"require-dev": {
 		"phing/phing": "2.17.4",
diff --git a/tests/Sniffs/Namespaces/UnusedUsesSniffTest.php b/tests/Sniffs/Namespaces/UnusedUsesSniffTest.php
@@ -68,6 +68,7 @@ public function testUnusedUse(): void
 		self::assertNoSniffError($report, 29);
 
 		self::assertNoSniffError($report, 30);
+		self::assertNoSniffError($report, 31);
 
 		self::assertNoSniffError($report, 91);
 	}
diff --git a/tests/Sniffs/Namespaces/data/unusedUses.php b/tests/Sniffs/Namespaces/data/unusedUses.php
@@ -28,6 +28,7 @@
 use ReferenceClass;
 use ClassWithStaticVariable;
 use ClassWithConstant;
+use function Psl\Type\null;
 
 class TestClass implements FirstInterface, SecondInterface
 {
@@ -67,3 +68,5 @@ protected function withUnion(UnionType|UnionType2|bool $union)
 	}
 
 }
+
+null();

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ public function testUnusedUse(): void`
`68`	`68`	`self::assertNoSniffError($report, 29);`
`69`	`69`
`70`	`70`	`self::assertNoSniffError($report, 30);`
	`71`	`+ self::assertNoSniffError($report, 31);`
`71`	`72`
`72`	`73`	`self::assertNoSniffError($report, 91);`
`73`	`74`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@`
`28`	`28`	`use ReferenceClass;`
`29`	`29`	`use ClassWithStaticVariable;`
`30`	`30`	`use ClassWithConstant;`
	`31`	`+use function Psl\Type\null;`
`31`	`32`
`32`	`33`	`class TestClass implements FirstInterface, SecondInterface`
`33`	`34`	`{`
`@@ -67,3 +68,5 @@ protected function withUnion(UnionType\|UnionType2\|bool $union)`
`67`	`68`	`}`
`68`	`69`
`69`	`70`	`}`
	`71`	`+`
	`72`	`+null();`