RequireConstructorPropertyPromotionSniff: Fixed false positives

Author: kukulich

SlevomatCodingStandard/Sniffs/Classes/RequireConstructorPropertyPromotionSniff.php

@@ -26,12 +26,14 @@
 use const T_CALLABLE;
 use const T_CLOSE_CURLY_BRACKET;
 use const T_COMMA;
+use const T_DEC;
 use const T_ELLIPSIS;
 use const T_ELSE;
 use const T_ELSEIF;
 use const T_EQUAL;
 use const T_FUNCTION;
 use const T_IF;
+use const T_INC;
 use const T_OBJECT_OPERATOR;
 use const T_OPEN_CURLY_BRACKET;
 use const T_OPEN_PARENTHESIS;
@@ -377,6 +379,15 @@ private function isParameterModifiedBeforeAssigment(
 			if (in_array($tokens[$nextPointer]['code'], Tokens::$assignmentTokens, true)) {
 				return true;
 			}
+
+			if ($tokens[$nextPointer]['code'] === T_INC) {
+				return true;
+			}
+
+			$previousPointer = TokenHelper::findNextEffective($phpcsFile, $i - 1);
+			if ($tokens[$previousPointer]['code'] === T_DEC) {
+				return true;
+			}
 		}
 
 		return false;

tests/Sniffs/Classes/data/requireConstructorPropertyPromotionNoErrors.php

@@ -75,7 +75,10 @@ class Nothing
 	#[SomeAttribute]
 	private $k;
 
-	public function __construct($a, $c, $d, $e, $f, $g, $h, string $i, string $j, $k)
+	private int $l;
+	private int $m;
+
+	public function __construct($a, $c, $d, $e, $f, $g, $h, string $i, string $j, $k, int $l, int $m)
 	{
 		$phpVersion = phpversion();
 
@@ -102,6 +105,12 @@ public function __construct($a, $c, $d, $e, $f, $g, $h, string $i, string $j, $k
 		$this->j = $j;
 
 		$this->k = $k;
+
+		$l++;
+		$this->l = $l;
+
+		--$m;
+		$this->m = $m;
 	}
 
 }