UnusedPrivateElementsSniff: Fixed false positive with constant in string

Author: kukulich

SlevomatCodingStandard/Sniffs/Classes/UnusedPrivateElementsSniff.php

@@ -225,6 +225,15 @@ public function process(\PHP_CodeSniffer\Files\File $phpcsFile, $classPointer):
 						unset($reportedProperties[$propertyInString]);
 					}
 				}
+				if (preg_match_all('~(?:self|static)::(.+?\b)~', $token['content'], $matches, PREG_PATTERN_ORDER)) {
+					foreach ($matches[1] as $constantInString) {
+						if (!isset($reportedConstants[$constantInString])) {
+							continue;
+						}
+
+						unset($reportedConstants[$constantInString]);
+					}
+				}
 				if (preg_match_all('~(?<=\{)\$this->(.+?\b)(?=\()~', $token['content'], $matches, PREG_PATTERN_ORDER)) {
 					foreach ($matches[1] as $methodInString) {
 						$normalizedMethodInString = $this->getNormalizedMethodName($methodInString);

tests/Sniffs/Classes/UnusedPrivateElementsSniffTest.php

@@ -115,6 +115,8 @@ public function testErrors(): void
 			UnusedPrivateElementsSniff::CODE_UNUSED_PROPERTY,
 			'Class ClassWithSomeUnusedProperties contains unused property $propertyWithPrefixUnsetAnnotation.'
 		);
+
+		self::assertNoSniffError($resultFile, 182);
 	}
 
 	public function testOnlyPublicElements(): void

tests/Sniffs/Classes/data/classWithSomeUnusedElements.php

@@ -179,4 +179,11 @@ public function createNewInstancesWithParentheses()
 	 */
 	private $propertyWithPrefixUnsetAnnotation;
 
+	private const USED_CONSTANT_IN_STRING = false;
+
+	public function usedConstantInString()
+	{
+		echo "{$this->whatever(self::USED_CONSTANT_IN_STRING)}";
+	}
+
 }