RequireMultiLineCallSniff: Speedup

Author: kukulich

SlevomatCodingStandard/Sniffs/Functions/RequireMultiLineCallSniff.php

@@ -167,34 +167,36 @@ public function process(File $phpcsFile, $stringPointer): void
 	private function shouldBeSkipped(File $phpcsFile, int $stringPointer, int $parenthesisCloserPointer): bool
 	{
 		$tokens = $phpcsFile->getTokens();
+		$nameTokenCodes = TokenHelper::getOnlyNameTokenCodes();
 
-		$firstPointerOnLine = TokenHelper::findFirstNonWhitespaceOnLine($phpcsFile, $stringPointer);
-		$stringPointersBefore = TokenHelper::findNextAll(
-			$phpcsFile,
-			TokenHelper::getOnlyNameTokenCodes(),
-			$firstPointerOnLine,
-			$stringPointer
-		);
+		$searchStartPointer = TokenHelper::findFirstNonWhitespaceOnLine($phpcsFile, $stringPointer);
+		while (true) {
+			$stringPointerBefore = TokenHelper::findNext($phpcsFile, $nameTokenCodes, $searchStartPointer, $stringPointer);
+
+			if ($stringPointerBefore === null) {
+				break;
+			}
 
-		foreach ($stringPointersBefore as $stringPointerBefore) {
 			$pointerAfterStringPointerBefore = TokenHelper::findNextEffective($phpcsFile, $stringPointerBefore + 1);
 			if (
 				$tokens[$pointerAfterStringPointerBefore]['code'] === T_OPEN_PARENTHESIS
 				&& $tokens[$pointerAfterStringPointerBefore]['parenthesis_closer'] > $stringPointer
 			) {
 				return true;
 			}
+
+			$searchStartPointer = $stringPointerBefore + 1;
 		}
 
 		$lastPointerOnLine = TokenHelper::findLastTokenOnLine($phpcsFile, $parenthesisCloserPointer);
-		$stringPointersAfter = TokenHelper::findNextAll(
-			$phpcsFile,
-			TokenHelper::getOnlyNameTokenCodes(),
-			$parenthesisCloserPointer + 1,
-			$lastPointerOnLine + 1
-		);
+		$searchStartPointer = $parenthesisCloserPointer + 1;
+		while (true) {
+			$stringPointerAfter = TokenHelper::findNext($phpcsFile, $nameTokenCodes, $searchStartPointer, $lastPointerOnLine + 1);
+
+			if ($stringPointerAfter === null) {
+				break;
+			}
 
-		foreach ($stringPointersAfter as $stringPointerAfter) {
 			$pointerAfterStringPointerAfter = TokenHelper::findNextEffective($phpcsFile, $stringPointerAfter + 1);
 			if (
 				$pointerAfterStringPointerAfter !== null
@@ -207,6 +209,8 @@ private function shouldBeSkipped(File $phpcsFile, int $stringPointer, int $paren
 			) {
 				return true;
 			}
+
+			$searchStartPointer = $stringPointerAfter + 1;
 		}
 
 		return false;