SlevomatCodingStandard.ControlStructures.RequireMultiLineTernaryOperator: Workaround for missing property hooks support in PHPCS

Author: kukulich

SlevomatCodingStandard/Helpers/TernaryOperatorHelper.php

@@ -31,6 +31,13 @@
 class TernaryOperatorHelper
 {
 
+	public static function is(File $phpcsFile, int $pointer): bool
+	{
+		$previousPointer = TokenHelper::findPreviousEffective($phpcsFile, $pointer - 1);
+
+		return $phpcsFile->getTokens()[$previousPointer]['code'] !== T_OPEN_PARENTHESIS;
+	}
+
 	public static function isConditionOfTernaryOperator(File $phpcsFile, int $pointer): bool
 	{
 		$inlineThenPointer = TokenHelper::findNext($phpcsFile, T_INLINE_THEN, $pointer + 1);

SlevomatCodingStandard/Sniffs/ControlStructures/RequireMultiLineTernaryOperatorSniff.php

@@ -40,6 +40,10 @@ public function register(): array
 
 	public function process(File $phpcsFile, int $inlineThenPointer): void
 	{
+		if (!TernaryOperatorHelper::is($phpcsFile, $inlineThenPointer)) {
+			return;
+		}
+
 		$this->lineLengthLimit = SniffSettingsHelper::normalizeInteger($this->lineLengthLimit);
 		$this->minExpressionsLength = SniffSettingsHelper::normalizeNullableInteger($this->minExpressionsLength);
 

tests/Sniffs/ControlStructures/RequireMultiLineTernaryOperatorSniffTest.php

@@ -10,7 +10,7 @@ class RequireMultiLineTernaryOperatorSniffTest extends TestCase
 	public function testNoErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/requireMultiLineTernaryOperatorNoErrors.php', [
-			'lineLengthLimit' => 80,
+			'lineLengthLimit' => 100,
 		]);
 		self::assertNoSniffErrorInFile($report);
 	}

tests/Sniffs/ControlStructures/data/requireMultiLineTernaryOperatorNoErrors.php

@@ -1,4 +1,4 @@
-<?php $a = $b === 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' ? 'bbbb' : 'ccccccc';
+<?php /* lint >= 8.4 */ $a = $b === 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' ? 'bbbb' : 'ccccccc';
 
 $a = $b === 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' ? 'bbbb' : 'ccccccc';
 
@@ -45,3 +45,12 @@
 $a = $b === 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' ? 'bbbb' : 'ccccccccccccc';
 
 $a = $b === 'bbbbbbbbbbbbbb' ? 'bbbb' : doSomething([], $c);
+
+class Foo {
+	public private(set) ?string $property {
+		get => null;
+		set(?string $value) {
+			$this->otherProperty = $value;
+		}
+	}
+}