UnusedUsesSniff: Fixed false positive

Author: kukulich

SlevomatCodingStandard/Helpers/ReferencedNameHelper.php

@@ -37,6 +37,7 @@
 use const T_OPEN_PARENTHESIS;
 use const T_OPEN_SHORT_ARRAY;
 use const T_OPEN_TAG;
+use const T_PARAM_NAME;
 use const T_TRAIT;
 use const T_TYPE_UNION;
 use const T_USE;
@@ -207,6 +208,17 @@ private static function getReferenceType(File $phpcsFile, int $nameStartPointer,
 			return ReferencedName::TYPE_CLASS;
 		}
 
+		if ($tokens[$previousTokenBeforeStartPointer]['code'] === T_COLON) {
+			$previousTokenPointer = TokenHelper::findPreviousEffective($phpcsFile, $previousTokenBeforeStartPointer - 1);
+
+			if ($tokens[$previousTokenPointer]['code'] === T_PARAM_NAME) {
+				return ReferencedName::TYPE_CONSTANT;
+			}
+
+			// Return type hint
+			return ReferencedName::TYPE_CLASS;
+		}
+
 		if (
 			in_array($tokens[$previousTokenBeforeStartPointer]['code'], [
 				T_EXTENDS,
@@ -215,8 +227,6 @@ private static function getReferenceType(File $phpcsFile, int $nameStartPointer,
 				// Trait
 				T_USE,
 				T_NEW,
-				// Return type hint
-				T_COLON,
 				// Nullable type hint
 				T_NULLABLE,
 			], true)

tests/Helpers/ReferencedNameHelperTest.php

@@ -63,6 +63,8 @@ public function testGetAllReferencedNames(): void
 			['\Union\UnionType4', false, false],
 			['UnionType5', false, false],
 			['UnionType6', false, false],
+			['str_pad', true, false],
+			['STR_PAD_RIGHT', false, true],
 		];
 
 		$names = ReferencedNameHelper::getAllReferencedNames($phpcsFile, 0);

tests/Helpers/data/lotsOfReferencedNames.php

@@ -9,6 +9,7 @@
 use function DI\string;
 use function doSomething;
 use function stream_wrapper_restore;
+use const STR_PAD_RIGHT;
 use const STREAM_URL_STAT_QUIET;
 
 class FooClass extends \ExtendedClass implements \ImplementedInterface, \SecondImplementedInterface, \ThirdImplementedInterface
@@ -161,3 +162,5 @@ public function call2(bool|UnionType6 $union)
 	}
 
 }
+
+echo str_pad('123', 1, pad_type: STR_PAD_RIGHT);

tests/Sniffs/Namespaces/UnusedUsesSniffTest.php

@@ -83,6 +83,7 @@ public function testUsedFunction(): void
 	public function testUsedConstant(): void
 	{
 		self::assertNoSniffError($this->getFileReport(), 15);
+		self::assertNoSniffError($this->getFileReport(), 26);
 	}
 
 	public function testUsedClassesInImplements(): void

tests/Sniffs/Namespaces/data/unusedUses.php

@@ -23,6 +23,7 @@
 use PartialNamespace;
 use UnionType;
 use UnionType2;
+use const STR_PAD_RIGHT;
 
 class TestClass implements FirstInterface, SecondInterface
 {
@@ -44,6 +45,8 @@ public function test(S $s): Rasmus
 		PartialConstant\USED_CONSTANT;
 		new PartialNamespace\UsedClass();
 
+		echo str_pad('123', 1, pad_type: STR_PAD_RIGHT);
+
 		return new NewObject();
 	}