ModernClassNameReferenceSniff: Fixed error messages

Author: kukulich

SlevomatCodingStandard/Sniffs/Classes/ModernClassNameReferenceSniff.php

@@ -12,6 +12,7 @@
 use const T_STRING;
 use const T_VARIABLE;
 use function in_array;
+use function sprintf;
 use function strtolower;
 
 class ModernClassNameReferenceSniff implements Sniff
@@ -50,7 +51,7 @@ public function process(File $phpcsFile, $pointer): void
 
 	private function checkMagicConstant(File $phpcsFile, int $pointer): void
 	{
-		$fix = $phpcsFile->addFixableError('Class name referenced via magic constant', $pointer, self::CODE_CLASS_NAME_REFERENCED_VIA_MAGIC_CONSTANT);
+		$fix = $phpcsFile->addFixableError('Class name referenced via magic constant.', $pointer, self::CODE_CLASS_NAME_REFERENCED_VIA_MAGIC_CONSTANT);
 
 		if (!$fix) {
 			return;
@@ -111,7 +112,7 @@ private function checkFunctionCall(File $phpcsFile, int $pointer): void
 			$fixedContent = 'static::class';
 		}
 
-		$fix = $phpcsFile->addFixableError('Class name referenced via call of function %s', $pointer, self::CODE_CLASS_NAME_REFERENCED_VIA_FUNCTION_CALL);
+		$fix = $phpcsFile->addFixableError(sprintf('Class name referenced via call of function %s().', $functionName), $pointer, self::CODE_CLASS_NAME_REFERENCED_VIA_FUNCTION_CALL);
 
 		if (!$fix) {
 			return;

tests/Sniffs/Classes/ModernClassNameReferenceSniffTest.php

@@ -20,10 +20,10 @@ public function testErrors(): void
 		self::assertSame(5, $report->getErrorCount());
 
 		self::assertSniffError($report, 12, ModernClassNameReferenceSniff::CODE_CLASS_NAME_REFERENCED_VIA_MAGIC_CONSTANT);
-		self::assertSniffError($report, 17, ModernClassNameReferenceSniff::CODE_CLASS_NAME_REFERENCED_VIA_FUNCTION_CALL);
-		self::assertSniffError($report, 22, ModernClassNameReferenceSniff::CODE_CLASS_NAME_REFERENCED_VIA_FUNCTION_CALL);
-		self::assertSniffError($report, 27, ModernClassNameReferenceSniff::CODE_CLASS_NAME_REFERENCED_VIA_FUNCTION_CALL);
-		self::assertSniffError($report, 32, ModernClassNameReferenceSniff::CODE_CLASS_NAME_REFERENCED_VIA_FUNCTION_CALL);
+		self::assertSniffError($report, 17, ModernClassNameReferenceSniff::CODE_CLASS_NAME_REFERENCED_VIA_FUNCTION_CALL, 'Class name referenced via call of function get_class().');
+		self::assertSniffError($report, 22, ModernClassNameReferenceSniff::CODE_CLASS_NAME_REFERENCED_VIA_FUNCTION_CALL, 'Class name referenced via call of function get_class().');
+		self::assertSniffError($report, 27, ModernClassNameReferenceSniff::CODE_CLASS_NAME_REFERENCED_VIA_FUNCTION_CALL, 'Class name referenced via call of function get_parent_class().');
+		self::assertSniffError($report, 32, ModernClassNameReferenceSniff::CODE_CLASS_NAME_REFERENCED_VIA_FUNCTION_CALL, 'Class name referenced via call of function get_called_class().');
 
 		self::assertAllFixedInFile($report);
 	}