StrictCallSniff: Fixed false positive

Author: kukulich

SlevomatCodingStandard/Sniffs/Functions/StrictCallSniff.php

@@ -56,6 +56,8 @@ public function process(File $phpcsFile, $stringPointer): void
 			return;
 		}
 
+		$parenthesisCloserPointer = $tokens[$parenthesisOpenerPointer]['parenthesis_closer'];
+
 		$functionName = strtolower($tokens[$stringPointer]['content']);
 
 		if (!array_key_exists($functionName, self::FUNCTIONS)) {
@@ -68,7 +70,7 @@ public function process(File $phpcsFile, $stringPointer): void
 		}
 
 		$commaPointers = [];
-		for ($i = $parenthesisOpenerPointer + 1; $i < $tokens[$parenthesisOpenerPointer]['parenthesis_closer']; $i++) {
+		for ($i = $parenthesisOpenerPointer + 1; $i < $parenthesisCloserPointer; $i++) {
 			if ($tokens[$i]['code'] === T_OPEN_PARENTHESIS) {
 				$i = $tokens[$i]['parenthesis_closer'];
 				continue;
@@ -88,19 +90,25 @@ public function process(File $phpcsFile, $stringPointer): void
 
 		$parametersCount = $commaPointersCount + 1;
 		$lastCommaPointer = $commaPointersCount > 0 ? $commaPointers[$commaPointersCount - 1] : null;
+		$hasTrailingComma = false;
 
 		if (
 			$lastCommaPointer !== null
-			&& TokenHelper::findNextEffective($phpcsFile, $lastCommaPointer + 1, $tokens[$parenthesisOpenerPointer]['parenthesis_closer']) === null
+			&& TokenHelper::findNextEffective($phpcsFile, $lastCommaPointer + 1, $parenthesisCloserPointer) === null
 		) {
+			$hasTrailingComma = true;
 			$parametersCount--;
 		}
 
 		if ($parametersCount === self::FUNCTIONS[$functionName]) {
 
-			$strictParameterValue = strtolower(trim(TokenHelper::getContent($phpcsFile, $lastCommaPointer + 1, $tokens[$parenthesisOpenerPointer]['parenthesis_closer'] - 1)));
+			$strictParameterValue = TokenHelper::getContent(
+				$phpcsFile,
+				$commaPointers[self::FUNCTIONS[$functionName] - 2] + 1,
+				($hasTrailingComma ? $lastCommaPointer : $parenthesisCloserPointer) - 1
+			);
 
-			if ($strictParameterValue === 'true') {
+			if (strtolower(trim($strictParameterValue)) === 'true') {
 				return;
 			}
 

tests/Sniffs/Functions/StrictCallSniffTest.php

@@ -17,7 +17,7 @@ public function testErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/strictCallErrors.php');
 
-		self::assertSame(6, $report->getErrorCount());
+		self::assertSame(7, $report->getErrorCount());
 
 		self::assertSniffError($report, 3, StrictCallSniff::CODE_STRICT_PARAMETER_MISSING);
 		self::assertSniffError($report, 4, StrictCallSniff::CODE_STRICT_PARAMETER_MISSING);
@@ -26,6 +26,7 @@ public function testErrors(): void
 		self::assertSniffError($report, 10, StrictCallSniff::CODE_NON_STRICT_COMPARISON);
 		self::assertSniffError($report, 11, StrictCallSniff::CODE_NON_STRICT_COMPARISON);
 		self::assertSniffError($report, 16, StrictCallSniff::CODE_NON_STRICT_COMPARISON);
+		self::assertSniffError($report, 18, StrictCallSniff::CODE_NON_STRICT_COMPARISON);
 	}
 
 }

tests/Sniffs/Functions/data/strictCallErrors.php

@@ -14,3 +14,12 @@
 	false,
 );
 base64_decode('', false);
+
+in_array(
+	0,
+	[
+		1,
+		2,
+	],
+	false,
+);

tests/Sniffs/Functions/data/strictCallNoErrors.php

@@ -2,7 +2,6 @@
 
 namespace Foo;
 
-use SlevomatCodingStandard\Helpers\ParameterTypeHint;
 use function array_filter;
 use function array_keys;
 
@@ -38,3 +37,18 @@ public static function array_search($a, $b)
 array_keys(
 	[],
 );
+
+in_array(
+	0,
+	[
+		1,
+		2,
+	],
+	true,
+);
+
+in_array(
+	$whatever,
+	$cache[$cacheKey],
+	true,
+);