UselessParenthesesSniff: Fixed false positive

Author: enumag

SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php

@@ -65,6 +65,7 @@
 use const T_USE;
 use const T_VARIABLE;
 use const T_WHITESPACE;
+use const T_YIELD;
 use const T_YIELD_FROM;
 
 class UselessParenthesesSniff implements Sniff
@@ -153,7 +154,7 @@ public function process(File $phpcsFile, $parenthesisOpenerPointer): void
 
 		/** @var int $pointerAfterParenthesisOpener */
 		$pointerAfterParenthesisOpener = TokenHelper::findNextEffective($phpcsFile, $parenthesisOpenerPointer + 1);
-		if (in_array($tokens[$pointerAfterParenthesisOpener]['code'], [T_NEW, T_CLONE, T_YIELD_FROM, T_REQUIRE, T_REQUIRE_ONCE, T_INCLUDE, T_INCLUDE_ONCE], true)) {
+		if (in_array($tokens[$pointerAfterParenthesisOpener]['code'], [T_NEW, T_CLONE, T_YIELD, T_YIELD_FROM, T_REQUIRE, T_REQUIRE_ONCE, T_INCLUDE, T_INCLUDE_ONCE], true)) {
 			return;
 		}
 

tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php

@@ -113,6 +113,7 @@ public function __construct()
 ] + $defaults('b'));
 
 function () {
+	$y = (yield whatever()) ?? $y;
 	$y = (yield from whatever()) ?? $y;
 };