ReferencedNameHelper: Fixed constant detection

Author: kukulich

SlevomatCodingStandard/Helpers/ReferencedNameHelper.php

@@ -148,13 +148,16 @@ private static function createAllReferencedNames(File $phpcsFile, int $openTagPo
 					if ($tokens[$previousTokenBeforeStartPointer]['code'] !== T_NEW) {
 						$type = ReferencedName::TYPE_FUNCTION;
 					}
+				} elseif ($tokens[$nextTokenAfterEndPointer]['code'] === T_BITWISE_AND) {
+					$tokenAfterNextToken = TokenHelper::findNextEffective($phpcsFile, $nextTokenAfterEndPointer + 1);
+					if (!in_array($tokens[$tokenAfterNextToken]['code'], [T_VARIABLE, T_ELLIPSIS], true)) {
+						$type = ReferencedName::TYPE_CONSTANT;
+					}
 				} elseif (
 					!in_array($tokens[$nextTokenAfterEndPointer]['code'], [
 						T_VARIABLE,
 						// Variadic parameter
 						T_ELLIPSIS,
-						// Parameter by reference
-						T_BITWISE_AND,
 					], true)
 				) {
 					if (

tests/Helpers/ReferencedNameHelperTest.php

@@ -54,6 +54,8 @@ public function testGetAllReferencedNames(): void
 			['string', true, false],
 			['doSomething', true, false],
 			['STREAM_URL_STAT_QUIET', false, true],
+			['E_ALL', false, true],
+			['E_NOTICE', false, true],
 		];
 
 		$names = ReferencedNameHelper::getAllReferencedNames($phpcsFile, 0);

tests/Helpers/data/lotsOfReferencedNames.php

@@ -124,3 +124,5 @@ function whatever($flags)
 
 	}
 }
+
+echo E_ALL & ~E_NOTICE;