UselessParenthesesSniff: Fixed false positive

kukulich · kukulich · commit bb8be4374e65 · 2019-12-12T11:16:23.000+01:00
diff --git a/SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php b/SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php
@@ -457,6 +457,10 @@ private function checkParenthesesAroundOperators(File $phpcsFile, int $parenthes
 			if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_MINUS && $tokens[$firstOperatorPointer]['code'] === T_PLUS) {
 				return;
 			}
+
+			if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_DIVIDE && $tokens[$firstOperatorPointer]['code'] === T_DIVIDE) {
+				return;
+			}
 		}
 
 		$lastOperatorPointer = $operatorsPointers[count($operatorsPointers) - 1];
diff --git a/tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php b/tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php
@@ -127,6 +127,8 @@ function () {
 
 $a = 10 + 1 - (5 + 4);
 
+$a = 10 / (5 / 2);
+
 pow(10, -($x + 1));
 
 if (! ($i === $j - 1)) {

Original file line number	Diff line number	Diff line change
`@@ -457,6 +457,10 @@ private function checkParenthesesAroundOperators(File $phpcsFile, int $parenthes`
`457`	`457`	`if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_MINUS && $tokens[$firstOperatorPointer]['code'] === T_PLUS) {`
`458`	`458`	`return;`
`459`	`459`	`}`
	`460`	`+`
	`461`	`+ if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_DIVIDE && $tokens[$firstOperatorPointer]['code'] === T_DIVIDE) {`
	`462`	`+ return;`
	`463`	`+ }`
`460`	`464`	`}`
`461`	`465`
`462`	`466`	`$lastOperatorPointer = $operatorsPointers[count($operatorsPointers) - 1];`