Ignore invalid @template and @type annotations

Author: kukulich

SlevomatCodingStandard/Helpers/TypeHintHelper.php

@@ -246,6 +246,10 @@ private static function isTemplate(File $phpcsFile, int $docCommentOpenPointer,
 
 				/** @var TemplateAnnotation $templateAnnotation */
 				foreach ($annotations[$templateAnnotationName] as $templateAnnotation) {
+					if ($templateAnnotation->isInvalid()) {
+						continue;
+					}
+
 					if ($templateAnnotation->getTemplateName() === $typeHint) {
 						return true;
 					}
@@ -329,6 +333,10 @@ private static function isAlias(File $phpcsFile, int $docCommentOpenPointer, str
 
 			/** @var TypeAliasAnnotation|TypeImportAnnotation $aliasAnnotation */
 			foreach ($annotations[$aliasAnnotationName] as $aliasAnnotation) {
+				if ($aliasAnnotation->isInvalid()) {
+					continue;
+				}
+
 				if ($aliasAnnotation->getAlias() === $typeHint) {
 					return true;
 				}

tests/Helpers/TypeHintHelperTest.php

@@ -346,4 +346,31 @@ public function testIsTypeDefinedInAnnotation(string $typeHintName, bool $isTemp
 		self::assertSame($isTemplate, TypeHintHelper::isTypeDefinedInAnnotation($phpcsFile, $docCommentOpenPointer, $typeHintName));
 	}
 
+	/**
+	 * @return mixed[][]
+	 */
+	public function dataIsTypeDefinedInAnnotationWhenAnnotationIsInvalid(): array
+	{
+		return [
+			[22, 'Alias'],
+			[29, 'Template'],
+		];
+	}
+
+	/**
+	 * @dataProvider dataIsTypeDefinedInAnnotationWhenAnnotationIsInvalid
+	 * @param int $line
+	 * @param string $type
+	 */
+	public function testIsTypeDefinedInAnnotationWhenAnnotationIsInvalid(int $line, string $type): void
+	{
+		$phpcsFile = $this->getCodeSnifferFile(__DIR__ . '/data/typeHintsDefinedInAnnotation.php');
+
+		$docCommentOpenPointer = $this->findPointerByLineAndType($phpcsFile, $line, T_DOC_COMMENT_OPEN_TAG);
+
+		self::assertNotNull($docCommentOpenPointer);
+
+		self::assertFalse(TypeHintHelper::isTypeDefinedInAnnotation($phpcsFile, $docCommentOpenPointer, $type));
+	}
+
 }

tests/Helpers/data/typeHintsDefinedInAnnotation.php

@@ -6,3 +6,32 @@
 function simpleFunction() {
 
 }
+
+/**
+ * @psalm-type Alias array<
+ *   string,
+ *   (class-string<Factory\FactoryInterface>|Factory\FactoryInterface)
+ *   |callable(ContainerInterface,string,array<mixed>|null)
+ * >
+ *
+ * @template
+ */
+class WithInvalidTypes
+{
+
+	/**
+	 * @return Alias
+	 */
+	public function withInvalidAlias() {
+
+	}
+
+	/**
+	 * @return Template
+	 */
+	public function withInvalidTemplate() {
+
+	}
+
+}
+