ControlStructureSpacingSniff: Fixed internal error

Author: kukulich

SlevomatCodingStandard/Sniffs/ControlStructures/ControlStructureSpacingSniff.php

@@ -2,6 +2,7 @@
 
 namespace SlevomatCodingStandard\Sniffs\ControlStructures;
 
+use Exception;
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Sniffs\Sniff;
 use PHP_CodeSniffer\Util\Tokens;
@@ -260,6 +261,10 @@ private function findControlStructureEnd(File $phpcsFile, int $controlStructureP
 				}
 
 				if ($tokens[$nextPointer]['code'] === T_ELSE) {
+					if (!array_key_exists('scope_closer', $tokens[$nextPointer])) {
+						throw new Exception('"else" without curly braces is not supported.');
+					}
+
 					return $tokens[$nextPointer]['scope_closer'];
 				}
 

tests/Sniffs/ControlStructures/ControlStructureSpacingSniffTest.php

@@ -4,6 +4,7 @@
 
 use SlevomatCodingStandard\Sniffs\Namespaces\UndefinedKeywordTokenException;
 use SlevomatCodingStandard\Sniffs\TestCase;
+use Throwable;
 
 class ControlStructureSpacingSniffTest extends TestCase
 {
@@ -153,4 +154,11 @@ public function testThrowExceptionForUndefinedConstant(): void
 		}
 	}
 
+	public function testElseWithoutCurlyBraces(): void
+	{
+		self::expectException(Throwable::class);
+		self::expectExceptionMessage('"else" without curly braces is not supported.');
+		self::checkFile(__DIR__ . '/data/controlStructureSpacingElseWithoutCurlyBraces.php');
+	}
+
 }

tests/Sniffs/ControlStructures/data/controlStructureSpacingElseWithoutCurlyBraces.php

@@ -0,0 +1,6 @@
+<?php
+
+if (true) {
+	return true;
+} else return false;
+