StrictCallSniff: Fixed false positive

Author: kukulich

SlevomatCodingStandard/Sniffs/Functions/StrictCallSniff.php

@@ -84,10 +84,19 @@ public function process(File $phpcsFile, $stringPointer): void
 			}
 		}
 
-		$parametersCount = count($commaPointers) + 1;
+		$commaPointersCount = count($commaPointers);
+
+		$parametersCount = $commaPointersCount + 1;
+		$lastCommaPointer = $commaPointersCount > 0 ? $commaPointers[$commaPointersCount - 1] : null;
+
+		if (
+			$lastCommaPointer !== null
+			&& TokenHelper::findNextEffective($phpcsFile, $lastCommaPointer + 1, $tokens[$parenthesisOpenerPointer]['parenthesis_closer']) === null
+		) {
+			$parametersCount--;
+		}
 
 		if ($parametersCount === self::FUNCTIONS[$functionName]) {
-			$lastCommaPointer = $commaPointers[count($commaPointers) - 1];
 
 			$strictParameterValue = strtolower(trim(TokenHelper::getContent($phpcsFile, $lastCommaPointer + 1, $tokens[$parenthesisOpenerPointer]['parenthesis_closer'] - 1)));
 

tests/Sniffs/Functions/StrictCallSniffTest.php

@@ -17,13 +17,15 @@ public function testErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/strictCallErrors.php');
 
-		self::assertSame(4, $report->getErrorCount());
+		self::assertSame(6, $report->getErrorCount());
 
 		self::assertSniffError($report, 3, StrictCallSniff::CODE_STRICT_PARAMETER_MISSING);
 		self::assertSniffError($report, 4, StrictCallSniff::CODE_STRICT_PARAMETER_MISSING);
+		self::assertSniffError($report, 5, StrictCallSniff::CODE_STRICT_PARAMETER_MISSING);
 
-		self::assertSniffError($report, 6, StrictCallSniff::CODE_NON_STRICT_COMPARISON);
-		self::assertSniffError($report, 7, StrictCallSniff::CODE_NON_STRICT_COMPARISON);
+		self::assertSniffError($report, 10, StrictCallSniff::CODE_NON_STRICT_COMPARISON);
+		self::assertSniffError($report, 11, StrictCallSniff::CODE_NON_STRICT_COMPARISON);
+		self::assertSniffError($report, 16, StrictCallSniff::CODE_NON_STRICT_COMPARISON);
 	}
 
 }

tests/Sniffs/Functions/data/strictCallErrors.php

@@ -2,6 +2,15 @@
 
 array_search(0, [1, 2]);
 array_keys([], 0);
+array_keys(
+	[],
+	0,
+);
 
 in_array(0, [], false);
+in_array(
+	0,
+	[],
+	false,
+);
 base64_decode('', false);

tests/Sniffs/Functions/data/strictCallNoErrors.php

@@ -35,3 +35,6 @@ public static function array_search($a, $b)
 
 in_array(0);
 array_keys([]);
+array_keys(
+	[],
+);