Skip to content

Commit d51e931

Browse files
committed
UnusedParameterSniff: Fixed false positive
1 parent d951b0c commit d51e931

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

SlevomatCodingStandard/Helpers/VariableHelper.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ public static function isUsedAsVariable(File $phpcsFile, int $variablePointer, i
8686
}
8787

8888
if ($tokens[$variableToCheckPointer - 1]['code'] === T_DOUBLE_COLON) {
89-
return false;
89+
$pointerAfterVariable = TokenHelper::findNextEffective($phpcsFile, $variableToCheckPointer + 1);
90+
return $tokens[$pointerAfterVariable]['code'] === T_OPEN_PARENTHESIS;
9091
}
9192

9293
if (ParameterHelper::isParameter($phpcsFile, $variableToCheckPointer)) {

tests/Sniffs/Functions/data/unusedParameterNoErrors.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,5 +73,10 @@ public function setProperty(string $property, $value): void
7373
$this->$property = $value;
7474
}
7575

76+
private static function staticMethodCallViaVariable(string $methodName): ?self
77+
{
78+
return self::$methodName();
79+
}
80+
7681
}
7782

0 commit comments

Comments
 (0)