UselessVariableSniff: Disable fixer for some codes

Author: kukulich

SlevomatCodingStandard/Sniffs/Variables/UselessVariableSniff.php

@@ -13,6 +13,7 @@
 use const T_MINUS_EQUAL;
 use const T_MOD_EQUAL;
 use const T_MUL_EQUAL;
+use const T_OPEN_CURLY_BRACKET;
 use const T_OR_EQUAL;
 use const T_PLUS_EQUAL;
 use const T_POW_EQUAL;
@@ -93,7 +94,19 @@ public function process(File $phpcsFile, $returnPointer): void
 			return;
 		}
 
-		$fix = $phpcsFile->addFixableError(sprintf('Useless variable %s.', $variableName), $previousVariablePointer, self::CODE_USELESS_VARIABLE);
+		$errorParameters = [
+			sprintf('Useless variable %s.', $variableName),
+			$previousVariablePointer,
+			self::CODE_USELESS_VARIABLE,
+		];
+
+		$pointerBeforePreviousVariable = TokenHelper::findPreviousEffective($phpcsFile, $previousVariablePointer - 1);
+		if (!in_array($tokens[$pointerBeforePreviousVariable]['code'], [T_SEMICOLON, T_OPEN_CURLY_BRACKET], true)) {
+			$phpcsFile->addError(...$errorParameters);
+			return;
+		}
+
+		$fix = $phpcsFile->addFixableError(...$errorParameters);
 
 		if (!$fix) {
 			return;

tests/Sniffs/Variables/UselessVariableSniffTest.php

@@ -17,7 +17,7 @@ public function testErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/uselessVariableErrors.php');
 
-		self::assertSame(15, $report->getErrorCount());
+		self::assertSame(17, $report->getErrorCount());
 
 		self::assertSniffError($report, 4, UselessVariableSniff::CODE_USELESS_VARIABLE, 'Useless variable $a.');
 		self::assertSniffError($report, 9, UselessVariableSniff::CODE_USELESS_VARIABLE, 'Useless variable $b.');
@@ -34,6 +34,8 @@ public function testErrors(): void
 		self::assertSniffError($report, 64, UselessVariableSniff::CODE_USELESS_VARIABLE, 'Useless variable $m.');
 		self::assertSniffError($report, 69, UselessVariableSniff::CODE_USELESS_VARIABLE, 'Useless variable $n.');
 		self::assertSniffError($report, 78, UselessVariableSniff::CODE_USELESS_VARIABLE, 'Useless variable $o.');
+		self::assertSniffError($report, 84, UselessVariableSniff::CODE_USELESS_VARIABLE, 'Useless variable $p.');
+		self::assertSniffError($report, 89, UselessVariableSniff::CODE_USELESS_VARIABLE, 'Useless variable $q.');
 
 		self::assertAllFixedInFile($report);
 	}

tests/Sniffs/Variables/data/uselessVariableErrors.fixed.php

@@ -62,3 +62,13 @@ function moreVariableOneWithoutAssigment() {
 	$o++;
 	return 10;
 }
+
+function assigmentAsFunctionParametr() {
+	doSomething($p = 0);
+	return $p;
+}
+
+function assigmentAfterAssignment() {
+	doSomething($qq = $q = 0);
+	return $q;
+}

tests/Sniffs/Variables/data/uselessVariableErrors.php

@@ -79,3 +79,13 @@ function moreVariableOneWithoutAssigment() {
 
 	return $o;
 }
+
+function assigmentAsFunctionParametr() {
+	doSomething($p = 0);
+	return $p;
+}
+
+function assigmentAfterAssignment() {
+	doSomething($qq = $q = 0);
+	return $q;
+}