UnusedVariableSniff: Fixed false positives

Author: kukulich

SlevomatCodingStandard/Sniffs/Variables/UnusedVariableSniff.php

@@ -88,7 +88,18 @@ public function process(File $phpcsFile, $variablePointer): void
 
 		$variableName = $tokens[$variablePointer]['content'];
 
-		if ($variableName === '$this') {
+		if (in_array($variableName, [
+			'$this',
+			'$GLOBALS',
+			'$_SERVER',
+			'$_GET',
+			'$_POST',
+			'$_FILES',
+			'$_COOKIE',
+			'$_SESSION',
+			'$_REQUEST',
+			'$_ENV',
+		], true)) {
 			return;
 		}
 

tests/Sniffs/Variables/data/unusedVariableNoErrors.php

@@ -276,3 +276,15 @@ function () {
 
 	return $a;
 };
+
+function () {
+	$GLOBALS = [];
+	$_SERVER = [];
+	$_GET = [];
+	$_POST = [];
+	$_FILES = [];
+	$_COOKIE = [];
+	$_SESSION = [];
+	$_REQUEST = [];
+	$_ENV = [];
+};