FullyQualifiedClassNameInAnnotationSniff supports more ways how to write inline doccomment

Author: kukulich

SlevomatCodingStandard/Sniffs/Namespaces/FullyQualifiedClassNameInAnnotationSniff.php

@@ -40,7 +40,14 @@ public function process(\PHP_CodeSniffer_File $phpcsFile, $annotationTagPointer)
 			return;
 		}
 
-		$typeHints = explode('|', preg_split('~\\s+~', trim($tokens[$annotationContentPointer]['content']))[0]);
+		$annotationContent = trim($tokens[$annotationContentPointer]['content']);
+		if ($annotationTagName === '@var' && preg_match('~^\$\\S+\\s+(.+)~', $annotationContent, $matches)) {
+			$typeHintsDefinition = $matches[1];
+		} else {
+			$typeHintsDefinition = preg_split('~\\s+~', $annotationContent)[0];
+		}
+
+		$typeHints = explode('|', $typeHintsDefinition);
 		foreach ($typeHints as $typeHint) {
 			$typeHint = preg_replace('~(\[\])+$~', '', $typeHint);
 			$lowercasedTypeHint = strtolower($typeHint);

tests/Sniffs/Namespaces/FullyQualifiedClassNameInAnnotationSniffTest.php

@@ -14,7 +14,7 @@ public function testErrors()
 	{
 		$report = $this->checkFile(__DIR__ . '/data/fullyQualifiedClassNameInAnnotationErrors.php');
 
-		$this->assertSame(11, $report->getErrorCount());
+		$this->assertSame(12, $report->getErrorCount());
 
 		$this->assertSniffError($report, 13, FullyQualifiedClassNameInAnnotationSniff::CODE_NON_FULLY_QUALIFIED_CLASS_NAME);
 		$this->assertSniffError($report, 17, FullyQualifiedClassNameInAnnotationSniff::CODE_NON_FULLY_QUALIFIED_CLASS_NAME);
@@ -27,6 +27,7 @@ public function testErrors()
 		$this->assertSniffError($report, 49, FullyQualifiedClassNameInAnnotationSniff::CODE_NON_FULLY_QUALIFIED_CLASS_NAME);
 		$this->assertSniffError($report, 57, FullyQualifiedClassNameInAnnotationSniff::CODE_NON_FULLY_QUALIFIED_CLASS_NAME, 'Class name \FooNamespace\FooClass in @return should be referenced via a fully qualified name');
 		$this->assertSniffError($report, 57, FullyQualifiedClassNameInAnnotationSniff::CODE_NON_FULLY_QUALIFIED_CLASS_NAME, 'Class name \Iterator in @return should be referenced via a fully qualified name');
+		$this->assertSniffError($report, 61, FullyQualifiedClassNameInAnnotationSniff::CODE_NON_FULLY_QUALIFIED_CLASS_NAME);
 	}
 
 }

tests/Sniffs/Namespaces/data/fullyQualifiedClassNameInAnnotationErrors.php

@@ -58,7 +58,8 @@ public function traversable()
 	 */
 	public function resultSet()
 	{
-
+		/** @var $coo FooClass */
+		$coo = $this->get();
 	}
 
 }

tests/Sniffs/Namespaces/data/fullyQualifiedClassNameInAnnotationNoErrors.php

@@ -20,6 +20,9 @@ public function __construct(string $foo)
 	{
 		/** @var self $boo */
 		$boo = $this->get();
+
+		/** @var $coo self */
+		$coo = $this->get();
 	}
 
 	/**