SlevomatCodingStandard.Classes.ClassConstantVisibility: Added support for final constants

Author: kukulich

SlevomatCodingStandard/Sniffs/Classes/ClassConstantVisibilitySniff.php

@@ -13,6 +13,7 @@
 use const T_ANON_CLASS;
 use const T_CLASS;
 use const T_CONST;
+use const T_FINAL;
 use const T_INTERFACE;
 use const T_PRIVATE;
 use const T_PROTECTED;
@@ -56,6 +57,10 @@ public function process(File $phpcsFile, $constantPointer): void
 		}
 
 		$visibilityPointer = TokenHelper::findPreviousEffective($phpcsFile, $constantPointer - 1);
+		if ($tokens[$visibilityPointer]['code'] === T_FINAL) {
+			$visibilityPointer = TokenHelper::findPreviousEffective($phpcsFile, $visibilityPointer - 1);
+		}
+
 		if (in_array($tokens[$visibilityPointer]['code'], [T_PUBLIC, T_PROTECTED, T_PRIVATE], true)) {
 			return;
 		}

tests/Sniffs/Classes/ClassConstantVisibilitySniffTest.php

@@ -11,7 +11,7 @@ public function testErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/classWithConstants.php');
 
-		self::assertSame(2, $report->getErrorCount());
+		self::assertSame(3, $report->getErrorCount());
 
 		self::assertNoSniffError($report, 7);
 		self::assertNoSniffError($report, 9);
@@ -30,6 +30,16 @@ public function testErrors(): void
 			ClassConstantVisibilitySniff::CODE_MISSING_CONSTANT_VISIBILITY,
 			'Constant class@anonymous::PUBLIC_FOO visibility missing.'
 		);
+
+		self::assertSniffError(
+			$report,
+			25,
+			ClassConstantVisibilitySniff::CODE_MISSING_CONSTANT_VISIBILITY,
+			'Constant class@anonymous::FINAL_WITHOUT_VISIBILITY visibility missing.'
+		);
+
+		self::assertNoSniffError($report, 26);
+		self::assertNoSniffError($report, 27);
 	}
 
 	public function testNoClassConstants(): void

tests/Sniffs/Classes/data/classWithConstants.php

@@ -1,4 +1,4 @@
-<?php
+<?php // lint >= 8.1
 
 class ClassWithConstants
 {
@@ -22,4 +22,7 @@ public function __construct()
 
 	const PUBLIC_FOO = 'public';
 
+	final const FINAL_WITHOUT_VISIBILITY = 'finalWithoutVisibility';
+	public final const FINAL_WITH_VISIBILITY = 'finalWithVisibility';
+	final public const FINAL_WITH_VISIBILITY2 = 'finalWithVisibility2';
 };