SlevomatCodingStandard.Classes.PropertyDeclaration: New option "checkPromoted" to enable check of promoted properties

Author: kukulich

README.md

@@ -547,6 +547,7 @@ Sniff provides the following settings:
 Sniff provides the following settings:
 
 * `modifiersOrder`: allows to configurure order of modifiers.
+* `checkPromoted`: will check promoted properties too.
 
 #### SlevomatCodingStandard.Classes.PropertySpacing 🔧
 

SlevomatCodingStandard/Sniffs/Classes/PropertyDeclarationSniff.php

@@ -52,6 +52,9 @@ class PropertyDeclarationSniff implements Sniff
 	/** @var string[]|null */
 	public $modifiersOrder = [];
 
+	/** @var bool */
+	public $checkPromoted = false;
+
 	/** @var array<int, array<int, (int|string)>>|null */
 	private $normalizedModifiersOrder = null;
 
@@ -88,7 +91,7 @@ public function process(File $phpcsFile, $modifierPointer): void
 			return;
 		}
 
-		if (!PropertyHelper::isProperty($phpcsFile, $propertyPointer)) {
+		if (!PropertyHelper::isProperty($phpcsFile, $propertyPointer, $this->checkPromoted)) {
 			return;
 		}
 

tests/Sniffs/Classes/PropertyDeclarationSniffTest.php

@@ -41,6 +41,32 @@ public function testErrors(): void
 		self::assertAllFixedInFile($report);
 	}
 
+	public function testPromotedNoErrors(): void
+	{
+		$report = self::checkFile(__DIR__ . '/data/propertyDeclarationPromotedNoErrors.php', [
+			'checkPromoted' => true,
+		]);
+		self::assertNoSniffErrorInFile($report);
+	}
+
+	public function testPromotedErrors(): void
+	{
+		$report = self::checkFile(__DIR__ . '/data/propertyDeclarationPromotedErrors.php', [
+			'checkPromoted' => true,
+		]);
+
+		self::assertSame(7, $report->getErrorCount());
+
+		self::assertSniffError($report, 6, PropertyDeclarationSniff::CODE_MULTIPLE_SPACES_BEFORE_TYPE_HINT);
+		self::assertSniffError($report, 6, PropertyDeclarationSniff::CODE_MULTIPLE_SPACES_BETWEEN_TYPE_HINT_AND_PROPERTY);
+		self::assertSniffError($report, 6, PropertyDeclarationSniff::CODE_INCORRECT_ORDER_OF_MODIFIERS);
+		self::assertSniffError($report, 16, PropertyDeclarationSniff::CODE_MULTIPLE_SPACES_BEFORE_TYPE_HINT);
+		self::assertSniffError($report, 16, PropertyDeclarationSniff::CODE_MULTIPLE_SPACES_BETWEEN_TYPE_HINT_AND_PROPERTY);
+		self::assertSniffError($report, 17, PropertyDeclarationSniff::CODE_INCORRECT_ORDER_OF_MODIFIERS);
+
+		self::assertAllFixedInFile($report);
+	}
+
 	public function testModifiedModifiersOrderNoErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/propertyDeclarationModifiedModifiersOrderNoErrors.php', [

tests/Sniffs/Classes/data/propertyDeclarationPromotedErrors.fixed.php

@@ -0,0 +1,22 @@
+<?php // lint >= 8.1
+
+class Whatever
+{
+
+	public function __construct(private int $promotion1, public readonly int $promotion2)
+	{
+	}
+
+}
+
+class Anything
+{
+
+	public function __construct(
+		private int $promotion3,
+		protected readonly Foo|Bar|null $promotion4,
+	)
+	{
+	}
+
+}

tests/Sniffs/Classes/data/propertyDeclarationPromotedErrors.php

@@ -0,0 +1,22 @@
+<?php // lint >= 8.1
+
+class Whatever
+{
+
+	public function __construct(private  int  $promotion1, readonly public  int $promotion2)
+	{
+	}
+
+}
+
+class Anything
+{
+
+	public function __construct(
+		private  int  $promotion3,
+		readonly protected Foo|Bar|null $promotion4,
+	)
+	{
+	}
+
+}

tests/Sniffs/Classes/data/propertyDeclarationPromotedNoErrors.php

@@ -0,0 +1,22 @@
+<?php // lint >= 8.1
+
+class Whatever
+{
+
+	public function __construct(private int $promotion1, public readonly int $promotion2)
+	{
+	}
+
+}
+
+class Anything
+{
+
+	public function __construct(
+		private int $promotion3,
+		public readonly Foo|Bar|null $promotion4,
+	)
+	{
+	}
+
+}