Skip to content

Commit fac13f6

Browse files
committed
fix(cli): Extract git_version from Docker image tag
- Add regex-based version extraction from image names like 'redis:7.4.0' or 'valkey/valkey:7.2.6-bookworm' - Pass extracted git_version to generate_benchmark_stream_request() - Enables by.version Redis TimeSeries keys to be created for CLI-triggered tests - Fixes test_dockerhub_via_cli and test_dockerhub_via_cli_airgap assertion failures
1 parent d00eb32 commit fac13f6

File tree

1 file changed

+16
-1
lines changed
  • redis_benchmarks_specification/__cli__

1 file changed

+16
-1
lines changed

redis_benchmarks_specification/__cli__/cli.py

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,21 @@ def trigger_tests_dockerhub_cli_command_logic(args, project_name, project_versio
8080
decode_responses=False,
8181
)
8282
conn.ping()
83+
84+
# Extract version from Docker image tag if possible
85+
# e.g., "redis:7.4.0" -> "7.4.0"
86+
# e.g., "valkey/valkey:7.2.6-bookworm" -> "7.2.6"
87+
git_version = None
88+
if ":" in args.run_image:
89+
tag = args.run_image.split(":")[-1]
90+
# Try to extract version number from tag
91+
# Common patterns: "7.4.0", "7.2.6-bookworm", "latest"
92+
import re
93+
version_match = re.match(r"^(\d+\.\d+\.\d+)", tag)
94+
if version_match:
95+
git_version = version_match.group(1)
96+
logging.info(f"Extracted git_version '{git_version}' from image tag")
97+
8398
testDetails = {}
8499
build_stream_fields, result = generate_benchmark_stream_request(
85100
args.id,
@@ -96,7 +111,7 @@ def trigger_tests_dockerhub_cli_command_logic(args, project_name, project_versio
96111
None,
97112
None,
98113
None,
99-
None,
114+
git_version, # Pass extracted version
100115
None,
101116
None,
102117
None,

0 commit comments

Comments
 (0)