Skip to content

Commit 367189d

Browse files
authored
Merge pull request SAML-Toolkits#493 from perryism/signed_element_id_message
Explicit about the error when signed element is not found and found m…
2 parents 65827d3 + c211906 commit 367189d

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

lib/onelogin/ruby-saml/response.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -821,6 +821,11 @@ def validate_signature
821821
end
822822

823823
if sig_elements.size != 1
824+
if sig_elements.size == 0
825+
append_error("Signed element id ##{doc.signed_element_id} is not found")
826+
else
827+
append_error("Signed element id ##{doc.signed_element_id} is found more than once")
828+
end
824829
return append_error(error_msg)
825830
end
826831

test/response_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -905,6 +905,7 @@ def generate_audience_error(expected, actual)
905905
response_wrapped.settings = settings
906906
assert !response_wrapped.send(:validate_signature)
907907
assert_includes response_wrapped.errors, "Invalid Signature on SAML Response"
908+
assert_includes response_wrapped.errors, "Signed element id #pfxc3d2b542-0f7e-8767-8e87-5b0dc6913375 is not found"
908909
end
909910
end
910911

0 commit comments

Comments
 (0)