Skip to content

Commit 5bb3a73

Browse files
committed
Release 1.6.0
1 parent 6313475 commit 5bb3a73

File tree

5 files changed

+25
-18
lines changed

5 files changed

+25
-18
lines changed

changelog.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
11
# RubySaml Changelog
2+
### 1.6.0 (November 27, 2017)
3+
# [#418](https://github.com/onelogin/ruby-saml/pull/418) Improve SAML message signature validation using original encoded parameters instead decoded in order to avoid conflicts (URL-encoding is not canonical, reported issues with ADFS)
4+
# [#420](https://github.com/onelogin/ruby-saml/pull/420) Expose NameID Format on SloLogoutrequest
5+
# [#423](https://github.com/onelogin/ruby-saml/pull/423) Allow format_cert to work with chained certificates
6+
# [#422](https://github.com/onelogin/ruby-saml/pull/422) Use to_s for requested attribute value
7+
8+
29
### 1.5.0 (August 31, 2017)
310
* [#400](https://github.com/onelogin/ruby-saml/pull/400) When validating Signature use stored IdP certficate if Signature contains no info about Certificate
411
* [#402](https://github.com/onelogin/ruby-saml/pull/402) Fix validate_response_state method that rejected SAMLResponses when using idp_cert_multi and idp_cert and idp_cert_fingerprint were not provided.

lib/onelogin/ruby-saml/utils.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def self.build_query_from_raw_parts(params)
9393
end
9494

9595
# Prepare raw GET parameters (build them from normal parameters
96-
# if not provided).
96+
# if not provided).
9797
#
9898
# @param rawparams [Hash] Raw GET Parameters
9999
# @param params [Hash] GET Parameters

lib/onelogin/ruby-saml/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module OneLogin
22
module RubySaml
3-
VERSION = '1.5.0'
3+
VERSION = '1.6.0'
44
end
55
end

test/logoutresponse_test.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -293,10 +293,10 @@ class RubySamlTest < Minitest::Test
293293
logoutresponse = OneLogin::RubySaml::Logoutresponse.new(params['SAMLResponse'], settings, options)
294294
# Assemble query string.
295295
query = OneLogin::RubySaml::Utils.build_query(
296-
type: 'SAMLResponse',
297-
data: params['SAMLResponse'],
298-
relay_state: params['RelayState'],
299-
sig_alg: params['SigAlg'],
296+
:type => 'SAMLResponse',
297+
:data => params['SAMLResponse'],
298+
:relay_state => params['RelayState'],
299+
:sig_alg => params['SigAlg']
300300
)
301301
# Modify the query string so that it encodes the same values,
302302
# but with different percent-encoding. Sanity-check that they
@@ -329,10 +329,10 @@ class RubySamlTest < Minitest::Test
329329
logoutresponse = OneLogin::RubySaml::Logoutresponse.new(params['SAMLResponse'], settings, options)
330330
# Assemble query string.
331331
query = OneLogin::RubySaml::Utils.build_query(
332-
type: 'SAMLResponse',
333-
data: params['SAMLResponse'],
334-
relay_state: params['RelayState'],
335-
sig_alg: params['SigAlg'],
332+
:type => 'SAMLResponse',
333+
:data => params['SAMLResponse'],
334+
:relay_state => params['RelayState'],
335+
:sig_alg => params['SigAlg']
336336
)
337337
# Modify the query string so that it encodes the same values,
338338
# but with different percent-encoding. Sanity-check that they

test/slo_logoutrequest_test.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -338,10 +338,10 @@ class RubySamlTest < Minitest::Test
338338
params = OneLogin::RubySaml::Logoutrequest.new.create_params(settings, "RelayState" => "http://example.com")
339339
# Assemble query string.
340340
query = OneLogin::RubySaml::Utils.build_query(
341-
type: 'SAMLRequest',
342-
data: params['SAMLRequest'],
343-
relay_state: params['RelayState'],
344-
sig_alg: params['SigAlg'],
341+
:type => 'SAMLRequest',
342+
:data => params['SAMLRequest'],
343+
:relay_state => params['RelayState'],
344+
:sig_alg => params['SigAlg']
345345
)
346346
# Modify the query string so that it encodes the same values,
347347
# but with different percent-encoding. Sanity-check that they
@@ -373,10 +373,10 @@ class RubySamlTest < Minitest::Test
373373
params = OneLogin::RubySaml::Logoutrequest.new.create_params(settings, "RelayState" => "http://example.com")
374374
# Assemble query string.
375375
query = OneLogin::RubySaml::Utils.build_query(
376-
type: 'SAMLRequest',
377-
data: params['SAMLRequest'],
378-
relay_state: params['RelayState'],
379-
sig_alg: params['SigAlg'],
376+
:type => 'SAMLRequest',
377+
:data => params['SAMLRequest'],
378+
:relay_state => params['RelayState'],
379+
:sig_alg => params['SigAlg']
380380
)
381381
# Modify the query string so that it encodes the same values,
382382
# but with different percent-encoding. Sanity-check that they

0 commit comments

Comments
 (0)