Skip to content

Commit 83c0259

Browse files
authored
Merge pull request SAML-Toolkits#376 from fenicks/fix-sp_name_qualifier
Fix SLO request on IDP who need the correct value for NameQualifier and SPNameQualifier (Shibboleth v3).
2 parents a65b68b + 5fb138b commit 83c0259

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

lib/onelogin/ruby-saml/logoutrequest.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ def create_logout_request_xml_doc(settings)
102102

103103
nameid = root.add_element "saml:NameID"
104104
if settings.name_identifier_value
105-
nameid.attributes['NameQualifier'] = settings.sp_name_qualifier if settings.sp_name_qualifier
105+
nameid.attributes['NameQualifier'] = settings.idp_name_qualifier if settings.idp_name_qualifier
106+
nameid.attributes['SPNameQualifier'] = settings.sp_name_qualifier if settings.sp_name_qualifier
106107
nameid.attributes['Format'] = settings.name_identifier_format if settings.name_identifier_format
107108
nameid.text = settings.name_identifier_value
108109
else

lib/onelogin/ruby-saml/settings.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ def initialize(overrides = {})
2929
attr_accessor :idp_cert_fingerprint
3030
attr_accessor :idp_cert_fingerprint_algorithm
3131
attr_accessor :idp_attribute_names
32+
attr_accessor :idp_name_qualifier
3233
# SP Data
3334
attr_accessor :issuer
3435
attr_accessor :assertion_consumer_service_url

0 commit comments

Comments
 (0)