Skip to content

Commit a22cc8d

Browse files
committed
Fix SAML-Toolkits#510 Add security warning about the use of nokogiri
1 parent 6ec0fba commit a22cc8d

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

README.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,17 @@ We created a demo project for Rails4 that uses the latest version of this librar
123123

124124
If you believe you have discovered a security vulnerability in this gem, please report it at https://www.onelogin.com/security with a description. We follow responsible disclosure guidelines, and will work with you to quickly find a resolution.
125125

126+
### Security warning
127+
128+
Some tools may incorrectly report ruby-saml is a potential security vulnerability.
129+
ruby-saml depends on Nokogiri, and it's possible to use Nokogiri in a dangerous way
130+
(by enabling its DTDLOAD option and disabling its NONET option).
131+
This dangerous Nokogiri configuration, which is sometimes used by other components,
132+
can create an XML External Entity (XXE) vulnerability if the XML data is not trusted.
133+
However, ruby-saml never enables this dangerous Nokogiri configuration;
134+
ruby-saml never enables DTDLOAD, and it never disables NONET.
135+
136+
126137
## Getting Started
127138
In order to use the toolkit you will need to install the gem (either manually or using Bundler), and require the library in your Ruby application:
128139

0 commit comments

Comments
 (0)