Be able to skip destination validation

Author: pitbulk

lib/onelogin/ruby-saml/response.rb

@@ -586,12 +586,14 @@ def validate_audience
         true
       end
 
-      # Validates the Destination, (If the SAML Response is received where expected)
+      # Validates the Destination, (If the SAML Response is received where expected).
+      # If the response was initialized with the :skip_destination option, this validation is skipped,
       # If fails, the error is added to the errors array
       # @return [Boolean] True if there is a Destination element that matches the Consumer Service URL, otherwise False
       #
       def validate_destination
         return true if destination.nil?
+        return true if options[:skip_destination]
 
         if destination.empty?
           error_msg = "The response has an empty Destination value"

test/response_test.rb

@@ -24,6 +24,7 @@ class RubySamlTest < Minitest::Test
     let(:response_no_conditions) { OneLogin::RubySaml::Response.new(read_invalid_response("no_conditions.xml.base64")) }
     let(:response_no_authnstatement) { OneLogin::RubySaml::Response.new(read_invalid_response("no_authnstatement.xml.base64")) }
     let(:response_empty_destination) { OneLogin::RubySaml::Response.new(read_invalid_response("empty_destination.xml.base64")) }
+    let(:response_empty_destination_with_skip) { OneLogin::RubySaml::Response.new(read_invalid_response("empty_destination.xml.base64"), {skip_destination: true}) }
     let(:response_no_status) { OneLogin::RubySaml::Response.new(read_invalid_response("no_status.xml.base64")) }
     let(:response_no_statuscode) { OneLogin::RubySaml::Response.new(read_invalid_response("no_status_code.xml.base64")) }
     let(:response_statuscode_responder) { OneLogin::RubySaml::Response.new(read_invalid_response("status_code_responder.xml.base64")) }
@@ -436,6 +437,12 @@ class RubySamlTest < Minitest::Test
         assert_includes response_empty_destination.errors, "The response has an empty Destination value"
       end
 
+      it "return true when the destination of the SAML Response is empty but skip_destination option is used" do
+        response_empty_destination_with_skip.settings = settings
+        assert response_empty_destination_with_skip.send(:validate_destination)
+        assert_empty response_empty_destination.errors
+      end
+
       it "returns true on a case insensitive match on the domain" do
         response_valid_signed_without_x509certificate.settings = settings
         response_valid_signed_without_x509certificate.settings.assertion_consumer_service_url = 'http://APP.muDa.no/sso/consume'