How to push mail credentials?

[sithumonline]

If we ignore it, it'll case to test the mail endpoint and in another hand it'll be security issue. so what we do???

[chamodshehanka]

I can remember azure has solution for this. can't remember that service name. so that GCP should have a solution as well.

[chamodshehanka]

There's an easy way, we can pass the credentials as node ENVs with start script like this

env NODE_ENV=local nodemon --exec 'ts-node' src/main.ts

So in your code first check the node envs are there else get them from config file.

[sithumonline]

export const MAIL = {
    HOST: process.env.MAIL_HOST || "smtp.mailtrap.io",
    PORT: process.env.MAIL_PORT || "2525",
    USER: process.env.MAIL_USER || "c8cca3941aea9c",
    PASSWORD: process.env.MAIL_PASSWORD || "18763bafd470a9",
}

Add something like above to config/index.js then import it to mail.constants.js, it'll solve both issues.

[sithumonline]

@susithrupasinghe can you implement this?

[susithrupasinghe]

@susithrupasinghe can you implement this?

Yeah i can. I will

[susithrupasinghe]

@ebonynon Fixed it now. #30

[susithrupasinghe]

Just give me a 30 minits. Still i'm on my bed.

…

On Mon, 1 Mar 2021, 9:44 am xe-non, ***@***.***> wrote: @susithrupasinghe <https://github.com/susithrupasinghe> can you implement this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGU4AHAMOFTNIZH7OHB537TTBMIDRANCNFSM4YLZMJUA> .