iron out binary interfaces

Author: midnight-wonderer

src/ObjectId.php

@@ -54,7 +54,7 @@ public function __construct(?string $rawData = null)
      * @return ObjectId
      * @throws Invalid if $rawData is not 12 bytes.
      */
-    public static function fromData(string $data): ObjectId
+    public static function fromBinary(string $data): ObjectId
     {
         return new self($data);
     }
@@ -71,7 +71,7 @@ public static function fromString(string $string): ObjectId
         if (!self::legal($string)) {
             throw new Invalid("'$string' is an invalid ObjectId.");
         }
-        return self::fromData(hex2bin($string));
+        return self::fromBinary(hex2bin($string));
     }
 
     /**
@@ -92,7 +92,7 @@ public static function fromTime(int|DateTime $time, bool $unique = true): Object
             $data = pack('N', $timestamp) . "\x00\x00\x00\x00\x00\x00\x00\x00";
         }
 
-        return self::fromData($data);
+        return self::fromBinary($data);
     }
 
     /**

tests/Unit/ObjectIdTest.php

@@ -14,14 +14,14 @@
 
     it('creates an ObjectId from raw data', function () {
         $rawId = random_bytes(12);
-        $objectId = ObjectId::fromData($rawId);
+        $objectId = ObjectId::fromBinary($rawId);
         expect($objectId)->toBeInstanceOf(ObjectId::class);
         expect($objectId->toBinary())->toBe($rawId);
     });
 
     it('throws Invalid exception for invalid raw data', function () {
         foreach ([10, 14] as $length) {
-            expect(fn() => ObjectId::fromData(random_bytes($length)))->toThrow(
+            expect(fn() => ObjectId::fromBinary(random_bytes($length)))->toThrow(
                 Invalid::class,
             );
         }