Add parameters to App::addErrorMiddleware

Author: odan

Slim/App.php

@@ -10,16 +10,20 @@
 
 namespace Slim;
 
+use Psr\Container\ContainerExceptionInterface;
 use Psr\Container\ContainerInterface;
+use Psr\Container\NotFoundExceptionInterface;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Server\MiddlewareInterface;
 use Psr\Http\Server\RequestHandlerInterface;
+use Psr\Log\LoggerInterface;
 use Slim\Interfaces\EmitterInterface;
 use Slim\Interfaces\RouterInterface;
 use Slim\Interfaces\ServerRequestCreatorInterface;
 use Slim\Middleware\EndpointMiddleware;
 use Slim\Middleware\ErrorExceptionMiddleware;
+use Slim\Middleware\ExceptionLoggingMiddleware;
 use Slim\Middleware\HtmlExceptionMiddleware;
 use Slim\Middleware\JsonExceptionMiddleware;
 use Slim\Middleware\RoutingMiddleware;
@@ -126,6 +130,7 @@ public function group(string $path, callable $handler): RouteGroup
 
     /**
      * Set the base path used for routing.
+     *
      * @param string $basePath
      */
     public function setBasePath(string $basePath): self
@@ -145,7 +150,6 @@ public function getBasePath(): string
 
     /**
      * Add a new middleware to the stack.
-     * @param MiddlewareInterface|callable|string $middleware
      */
     public function add(MiddlewareInterface|callable|string $middleware): self
     {
@@ -156,7 +160,6 @@ public function add(MiddlewareInterface|callable|string $middleware): self
 
     /**
      * Add a new middleware to the application's middleware stack.
-     * @param MiddlewareInterface $middleware
      */
     public function addMiddleware(MiddlewareInterface $middleware): self
     {
@@ -178,16 +181,39 @@ public function addRoutingMiddleware(): self
     }
 
     /**
-     * Add set of default error handling middleware.
+     * Add a set of default error handling middleware.
+     *
+     * @param bool $displayErrorDetails
+     * @param bool $logErrors
+     * @param bool $logErrorDetails
+     * @param LoggerInterface|null $logger
      *
      * @return self
      */
-    public function addErrorMiddleware(): self
-    {
-        return $this
+    public function addErrorMiddleware(
+        bool $displayErrorDetails = false,
+        bool $logErrors = true,
+        bool $logErrorDetails = true,
+        ?LoggerInterface $logger = null,
+    ): self {
+        $app = $this
             ->add(ErrorExceptionMiddleware::class)
-            ->add(HtmlExceptionMiddleware::class)
+            ->add($this->container->get(HtmlExceptionMiddleware::class)->withErrorDetails($displayErrorDetails))
             ->add(JsonExceptionMiddleware::class);
+
+        if ($logErrors) {
+            $loggingMiddleware = $this->container
+                ->get(ExceptionLoggingMiddleware::class)
+                ->withLogErrorDetails($logErrorDetails);
+
+            if ($logger) {
+                $loggingMiddleware = $loggingMiddleware->withLogger($logger);
+            }
+
+            $app->add($loggingMiddleware);
+        }
+
+        return $app;
     }
 
     /**
@@ -211,7 +237,6 @@ public function run(?ServerRequestInterface $request = null): void
      *
      * This method processes the request through the application's middleware stack and router,
      * returning the resulting HTTP response.
-     * @param ServerRequestInterface $request
      */
     public function handle(ServerRequestInterface $request): ResponseInterface
     {

Slim/Middleware/ExceptionLoggingMiddleware.php

@@ -58,6 +58,14 @@ public function withLogErrorDetails(bool $logErrorDetails): self
         return $clone;
     }
 
+    public function withLogger(LoggerInterface $logger): self
+    {
+        $clone = clone $this;
+        $clone->logger = $logger;
+
+        return $clone;
+    }
+
     /**
      * @param Throwable $exception
      * @param ServerRequestInterface $request