Skip to content

Commit 0cd1112

Browse files
committed
skia: Remove unnecessary union with the layer's own geometry
(as advised by Olivier and also done in femtovg)
1 parent 8fe4ff3 commit 0cd1112

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

internal/renderers/skia/itemrenderer.rs

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -326,16 +326,13 @@ impl<'a> SkiaItemRenderer<'a> {
326326
let current_clip = self.get_current_clip();
327327
if let Some((layer_offset, layer_image)) = self.render_layer(item_rc, &|| {
328328
// We don't need to include the size of the "layer" item itself, since it has no content.
329-
let children_rect = i_slint_core::properties::evaluate_no_tracking(|| {
330-
item_rc.geometry().union(
331-
&i_slint_core::item_rendering::item_children_bounding_rect(
332-
item_rc.item_tree(),
333-
item_rc.index() as isize,
334-
&current_clip,
335-
),
329+
i_slint_core::properties::evaluate_no_tracking(|| {
330+
i_slint_core::item_rendering::item_children_bounding_rect(
331+
item_rc.item_tree(),
332+
item_rc.index() as isize,
333+
&current_clip,
336334
)
337-
});
338-
children_rect
335+
})
339336
}) {
340337
let _saved_canvas = self.pixel_align_origin();
341338
self.canvas.translate(skia_safe::Vector::from((layer_offset.x, layer_offset.y)));

0 commit comments

Comments
 (0)