Link directly to individual global enums/structs in documentation #9600
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
added
the
a:documentation
|
Please use |
|
Once the === issue above is fixed we can approve and merge this in. |
Previously, we sent users to the top of the page whenever they click on a property that refers to a global enum/struct in our documentation. However the page is already filled with permalinks we can use, so I made it so we assume there's a permalink. If the permalink doesn't exist, it would just send them back to the top of the page anyway which was the previous status quo.
redstrate
force-pushed
the
work/josh/struct-enum-permalinking
branch
from
99e6145 to
969f3d2
Compare
|
Sorry about the delay, fixed that now |
NigelBreslaw
approved these changes
Oct 7, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we sent users to the top of the page whenever they click on a property that refers to a global enum/struct in our documentation. However the page is already filled with permalinks we can use, so I made it so we assume there's a permalink.
If the permalink doesn't exist, it would just send them back to the top of the page anyway which was the previous status quo.