Skip to content

Commit deab023

Browse files
committed
Fix WARN log GELF message has invalid "timestamp" (type: STRING)
1 parent 571f252 commit deab023

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/logback/GraylogExtendedLogFormatStructuredLogFormatter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ private static void jsonMembers(Environment environment, ThrowableProxyConverter
123123
* @param timeStamp the timestamp of the log message
124124
* @return the timestamp formatted as string with millisecond precision
125125
*/
126-
private static String formatTimeStamp(final long timeStamp) {
127-
return new BigDecimal(timeStamp).movePointLeft(3).toPlainString();
126+
private static double formatTimeStamp(final long timeStamp) {
127+
return new BigDecimal(timeStamp).movePointLeft(3).doubleValue();
128128
}
129129

130130
private static String formatFullMessageWithThrowable(ThrowableProxyConverter throwableProxyConverter,

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/logging/logback/GraylogExtendedLogFormatStructuredLogFormatterTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ void shouldFormat() {
5959
assertThat(json).endsWith("\n");
6060
Map<String, Object> deserialized = deserialize(json);
6161
assertThat(deserialized).containsExactlyInAnyOrderEntriesOf(map("version", "1.1", "host", "name", "timestamp",
62-
"1719910193.000", "level", 6, "_level_name", "INFO", "_process_pid", 1, "_process_thread_name", "main",
62+
1719910193.000D, "level", 6, "_level_name", "INFO", "_process_pid", 1, "_process_thread_name", "main",
6363
"_service_version", "1.0.0", "_service_environment", "test", "_service_node_name", "node-1",
6464
"_log_logger", "org.example.Test", "short_message", "message", "_mdc-1", "mdc-v-1", "_kv-1", "kv-v-1"));
6565
}

0 commit comments

Comments
 (0)