drop profileName parameter

Author: slobodanadamovic

x-pack/plugin/security/qa/rcs-extension/src/main/java/org/elasticsearch/xpack/security/rcs/extension/TestRemoteClusterSecurityExtension.java

@@ -55,7 +55,6 @@ public boolean isRemoteClusterConnection(Transport.Connection connection) {
 
             @Override
             public Optional<ServerTransportFilter> getRemoteProfileTransportFilter(
-                String profileName,
                 SslProfile sslProfile,
                 DestructiveOperations destructiveOperations
             ) {

x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/transport/CrossClusterAccessTransportInterceptor.java

@@ -53,7 +53,6 @@
 import java.util.function.Function;
 
 import static org.elasticsearch.core.Strings.format;
-import static org.elasticsearch.transport.RemoteClusterPortSettings.REMOTE_CLUSTER_PROFILE;
 import static org.elasticsearch.transport.RemoteClusterPortSettings.REMOTE_CLUSTER_SERVER_ENABLED;
 import static org.elasticsearch.transport.RemoteClusterPortSettings.TRANSPORT_VERSION_ADVANCED_REMOTE_CLUSTER_SECURITY;
 
@@ -325,13 +324,11 @@ public boolean isRemoteClusterConnection(Transport.Connection connection) {
 
     @Override
     public Optional<ServerTransportFilter> getRemoteProfileTransportFilter(
-        String profileName,
         SslProfile sslProfile,
         DestructiveOperations destructiveOperations
     ) {
-        assert REMOTE_CLUSTER_PROFILE.equals(profileName) : "should only be called for remote cluster transport profiles";
         final SslConfiguration profileConfiguration = sslProfile.configuration();
-        assert profileConfiguration != null : "SSL Profile [" + sslProfile + "] for [" + profileName + "] has a null configuration";
+        assert profileConfiguration != null : "SSL Profile [" + sslProfile + "] has a null configuration";
         final boolean remoteClusterServerEnabled = REMOTE_CLUSTER_SERVER_ENABLED.get(settings);
         final boolean remoteClusterServerSSLEnabled = XPackSettings.REMOTE_CLUSTER_SERVER_SSL_ENABLED.get(settings);
         if (remoteClusterServerEnabled) {

x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/transport/RemoteClusterTransportInterceptor.java

@@ -46,11 +46,7 @@ public interface RemoteClusterTransportInterceptor {
      * @return a custom {@link ServerTransportFilter}s for the given transport profile,
      *         or an empty optional to fall back to the default transport filter
      */
-    Optional<ServerTransportFilter> getRemoteProfileTransportFilter(
-        String profileName,
-        SslProfile sslProfile,
-        DestructiveOperations destructiveOperations
-    );
+    Optional<ServerTransportFilter> getRemoteProfileTransportFilter(SslProfile sslProfile, DestructiveOperations destructiveOperations);
 
     /**
      * Returns {@code true} if any of the remote cluster access headers are in the security context.

x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/transport/SecurityServerTransportInterceptor.java

@@ -92,7 +92,6 @@ private Map<String, ServerTransportFilter> initializeProfileFilters(
             final SslProfile sslProfile = entry.getValue();
             if (profileName.equals(REMOTE_CLUSTER_PROFILE)) {
                 var remoteProfileTransportFilter = this.remoteClusterTransportInterceptor.getRemoteProfileTransportFilter(
-                    profileName,
                     sslProfile,
                     destructiveOperations
                 );

x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/transport/CrossClusterAccessTransportInterceptorTests.java

@@ -849,7 +849,6 @@ public void testGetRemoteProfileTransportFilter() {
         );
 
         final Optional<ServerTransportFilter> remoteProfileTransportFilter = interceptor.getRemoteProfileTransportFilter(
-            RemoteClusterPortSettings.REMOTE_CLUSTER_PROFILE,
             remoteProfile,
             destructiveOperations
         );
@@ -901,7 +900,6 @@ public void testGetRemoteProfileTransportFilterWhenRemoteClusterServerIsDisabled
         );
 
         final Optional<ServerTransportFilter> remoteProfileTransportFilter = interceptor.getRemoteProfileTransportFilter(
-            RemoteClusterPortSettings.REMOTE_CLUSTER_PROFILE,
             remoteProfile,
             destructiveOperations
         );

x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/transport/SecurityServerTransportInterceptorTests.java

@@ -545,7 +545,6 @@ public boolean isRemoteClusterConnection(Connection connection) {
 
         @Override
         public Optional<ServerTransportFilter> getRemoteProfileTransportFilter(
-            String profileName,
             SslProfile sslProfile,
             DestructiveOperations destructiveOperations
         ) {