GUI: add context menu to every tree/list view (nicotine-plus#3513)

Some list/tree views were missing them, mainly in the Preferences
dialog.

Author: mathiascode

pynicotine/gtkgui/dialogs/chathistory.py

@@ -14,6 +14,8 @@
 from pynicotine.gtkgui.widgets import ui
 from pynicotine.gtkgui.widgets.accelerator import Accelerator
 from pynicotine.gtkgui.widgets.dialogs import Dialog
+from pynicotine.gtkgui.widgets.dialogs import OptionDialog
+from pynicotine.gtkgui.widgets.popupmenu import PopupMenu
 from pynicotine.gtkgui.widgets.theme import USER_STATUS_ICON_NAMES
 from pynicotine.gtkgui.widgets.treeview import TreeView
 from pynicotine.logfacility import log
@@ -38,6 +40,7 @@ def __init__(self, application):
             width=960,
             height=700
         )
+        application.add_window(self.widget)
 
         self.list_view = TreeView(
             application.window, parent=self.list_container, activate_row_callback=self.on_show_user,
@@ -68,6 +71,13 @@ def __init__(self, application):
             }
         )
 
+        self.popup_menu = PopupMenu(application, self.list_view.widget)
+        self.popup_menu.add_items(
+            ("#" + _("_Open Chat"), self.on_show_user),
+            ("", None),
+            ("#" + _("Delete Chat Log…"), self.on_delete_chat_log)
+        )
+
         Accelerator("<Primary>f", self.widget, self.on_search_accelerator)
 
         self.load_users()
@@ -80,7 +90,10 @@ def __init__(self, application):
             events.connect(event_name, callback)
 
     def destroy(self):
+
+        self.popup_menu.destroy()
         self.list_view.destroy()
+
         super().destroy()
 
     def server_login(self, msg):
@@ -235,6 +248,25 @@ def on_show_user(self, *_args):
             self.close()
             return
 
+    def on_delete_chat_log_response(self, _dialog, _response_id, username):
+        log.delete_log(log.private_chat_folder_path, username)
+        self.remove_user(username)
+
+    def on_delete_chat_log(self, *_args):
+
+        for iterator in self.list_view.get_selected_rows():
+            username = self.list_view.get_row_value(iterator, "user")
+
+            OptionDialog(
+                parent=self.parent,
+                title=_("Delete Logged Messages?"),
+                message=_("Do you really want to permanently delete all logged messages for this user?"),
+                destructive_response_id="ok",
+                callback=self.on_delete_chat_log_response,
+                callback_data=username
+            ).present()
+            return
+
     def on_search_accelerator(self, *_args):
         """Ctrl+F - Search users."""
 

pynicotine/gtkgui/dialogs/download.py

@@ -17,6 +17,7 @@
 from pynicotine.gtkgui.widgets.dialogs import EntryDialog
 from pynicotine.gtkgui.widgets.filechooser import FileChooserButton
 from pynicotine.gtkgui.widgets.infobar import InfoBar
+from pynicotine.gtkgui.widgets.popupmenu import PopupMenu
 from pynicotine.gtkgui.widgets.treeview import TreeView
 from pynicotine.utils import human_size
 from pynicotine.utils import humanize
@@ -58,6 +59,7 @@ def __init__(self, application):
             show_title_buttons=False
         )
         application.add_window(self.widget)
+
         self.application = application
         self.parent_iterators = {}
         self.initial_selected_iterators = set()
@@ -117,6 +119,11 @@ def __init__(self, application):
             }
         )
 
+        self.popup_menu = PopupMenu(application, self.tree_view.widget, self.on_popup_menu)
+        self.popup_menu.add_items(
+            ("#" + _("_Rename…"), self.on_rename)
+        )
+
         self.expand_button.connect("toggled", self.on_expand_tree)
 
         for event_name, callback in (
@@ -130,6 +137,7 @@ def destroy(self):
 
         self.clear()
 
+        self.popup_menu.destroy()
         self.download_folder_button.destroy()
         self.info_bar.destroy()
         self.tree_view.destroy()
@@ -468,6 +476,9 @@ def server_disconnect(self, *_args):
         if self.indeterminate_progress:
             self.set_failed()
 
+    def on_popup_menu(self, menu, _widget):
+        menu.actions[_("_Rename…")].set_enabled(self.rename_button.get_sensitive())
+
     def on_retry(self, *_args):
 
         self.set_in_progress()

pynicotine/gtkgui/dialogs/fastconfigure.py

@@ -14,6 +14,7 @@
 from pynicotine.gtkgui.widgets.filechooser import FolderChooser
 from pynicotine.gtkgui.widgets.dialogs import Dialog
 from pynicotine.gtkgui.widgets.dialogs import EntryDialog
+from pynicotine.gtkgui.widgets.popupmenu import PopupMenu
 from pynicotine.gtkgui.widgets.treeview import TreeView
 from pynicotine.slskmessages import UserStatus
 
@@ -62,6 +63,7 @@ def __init__(self, application):
             height=450,
             show_title=False
         )
+        application.add_window(self.widget)
 
         icon_name = pynicotine.__application_id__
         icon_args = (Gtk.IconSize.BUTTON,) if GTK_API_VERSION == 3 else ()  # pylint: disable=no-member
@@ -96,10 +98,18 @@ def __init__(self, application):
             }
         )
 
+        self.shares_popup_menu = PopupMenu(application, self.shares_list_view.widget)
+        self.shares_popup_menu.add_items(
+            ("#" + _("_Edit…"), self.on_edit_shared_folder),
+            ("", None),
+            ("#" + _("Remove"), self.on_remove_shared_folder)
+        )
+
         self.reset_completeness()
 
     def destroy(self):
 
+        self.shares_popup_menu.destroy()
         self.download_folder_button.destroy()
         self.shares_list_view.destroy()
 

pynicotine/gtkgui/dialogs/pluginsettings.py

@@ -11,6 +11,7 @@
 from pynicotine.gtkgui.widgets.dialogs import Dialog
 from pynicotine.gtkgui.widgets.dialogs import EntryDialog
 from pynicotine.gtkgui.widgets.filechooser import FileChooserButton
+from pynicotine.gtkgui.widgets.popupmenu import PopupMenu
 from pynicotine.gtkgui.widgets.textview import TextView
 from pynicotine.gtkgui.widgets.theme import add_css_class
 
@@ -51,8 +52,17 @@ def __init__(self, application):
             height=425,
             show_title_buttons=False
         )
+        application.add_window(self.widget)
 
     def destroy(self):
+
+        from pynicotine.gtkgui.widgets.treeview import TreeView
+
+        for widget in self.option_widgets.values():
+            if isinstance(widget, TreeView):
+                widget.popup_menu.destroy()
+                widget.destroy()
+
         self.__dict__.clear()
 
     @staticmethod
@@ -203,6 +213,13 @@ def _add_list_option(self, option_name, option_value, description):
         treeview.row_id = len(rows)
         self.application.preferences.set_widget(treeview, rows)
 
+        treeview.popup_menu = PopupMenu(self.application, treeview.widget)
+        treeview.popup_menu.add_items(
+            ("#" + _("_Edit…"), self.on_edit, treeview),
+            ("", None),
+            ("#" + _("Remove"), self.on_remove, treeview)
+        )
+
         button_container = Gtk.Box(margin_end=6, margin_bottom=6, margin_start=6, margin_top=6,
                                    spacing=6, visible=True)
 
@@ -364,7 +381,9 @@ def on_add_response(self, window, _response_id, treeview):
         treeview.row_id += 1
         treeview.add_row([value, treeview.row_id])
 
-    def on_add(self, _button, treeview):
+    def on_add(self, *args):
+
+        treeview = args[-1]
 
         EntryDialog(
             parent=self,
@@ -388,7 +407,9 @@ def on_edit_response(self, window, _response_id, data):
         treeview.remove_row(iterator)
         treeview.add_row([value, row_id])
 
-    def on_edit(self, _button=None, treeview=None):
+    def on_edit(self, *args):
+
+        treeview = args[-1]
 
         for iterator in treeview.get_selected_rows():
             value = treeview.get_row_value(iterator, "description") or ""
@@ -405,18 +426,21 @@ def on_edit(self, _button=None, treeview=None):
             ).present()
             return
 
-    def on_remove(self, _button=None, treeview=None):
+    def on_remove(self, *args):
+
+        treeview = args[-1]
+
         for iterator in reversed(list(treeview.get_selected_rows())):
             row_id = treeview.get_row_value(iterator, "id_data")
             orig_iterator = treeview.iterators[row_id]
 
             treeview.remove_row(orig_iterator)
 
     def on_row_activated(self, treeview, *_args):
-        self.on_edit(treeview=treeview)
+        self.on_edit(treeview)
 
     def on_delete_accelerator(self, treeview):
-        self.on_remove(treeview=treeview)
+        self.on_remove(treeview)
 
     def on_cancel(self, *_args):
         self.close()