remove jest-fetch-mock and initialProps from tests

Author: dagda1

package.json

@@ -62,8 +62,7 @@
       }
     },
     "setupFilesAfterEnv": [
-      "@testing-library/jest-dom/extend-expect",
-      "<rootDir>/test/setupTests.ts"
+      "@testing-library/jest-dom/extend-expect"
     ]
   },
   "devDependencies": {
@@ -74,7 +73,6 @@
     "@types/react": "^16.9.9",
     "@types/react-dom": "^16.9.2",
     "husky": "^2.2.0",
-    "jest-fetch-mock": "^2.1.2",
     "prettier": "^1.17.0",
     "pretty-quick": "^1.10.0",
     "react": "^16.10.2",

test/setupTests.ts

@@ -1,9 +1,6 @@
 import { useAsync, UseAsyncReturn } from '../src';
-import { FetchMock } from 'jest-fetch-mock/types';
 import { renderHook } from '@testing-library/react-hooks';
 
-const fetch: FetchMock = global.fetch;
-
 interface StarwarsHero {
   name: string;
 }
@@ -19,61 +16,34 @@ export const generateMockResponseData = (amount: number = 5): StarwarsHero[] =>
   }));
 
 describe('useAync', () => {
-  const fetchStarwarsHeroes = async (): Promise<StarwarsHero[]> => {
-    const result = await fetch(`https://swapi.co/api/people/`);
-
-    return await result.json();
-  };
-
-  const props = {
-    asyncFunction: fetchStarwarsHeroes,
-  };
-
   const fakeResults = generateMockResponseData();
 
-  beforeEach(() => {
-    fetch.resetMocks();
-  });
-
   it('should have a useAsync hook', () => {
     expect(useAsync).toBeDefined();
   });
 
-  it('should set loading flag when request is initially made', () => {
-    fetch.mockResponseOnce(JSON.stringify(fakeResults));
-
-    const { result } = renderHook<
-      StarwarsHeroArgs,
-      UseAsyncReturn<StarwarsHero[]>
-    >(p => useAsync<StarwarsHero[], any[]>(p.asyncFunction, []), {
-      initialProps: { ...props },
-    });
-
-    expect(result.current.loading).toBe(true);
-    expect(result.current.error).toBeUndefined();
-    expect(result.current.result).toBeUndefined();
-  });
-
   it('should resolve a successful request', async () => {
-    fetch.mockResponseOnce(JSON.stringify(fakeResults));
-
     const onSuccess = jest.fn();
     const onError = jest.fn();
 
     const { result, waitForNextUpdate } = renderHook<
       StarwarsHeroArgs,
       UseAsyncReturn<StarwarsHero[]>
-    >(
-      p =>
-        useAsync<StarwarsHero[], any>(p.asyncFunction, [], {
+    >(() =>
+      useAsync<StarwarsHero[], any>(
+        async () => {
+          return Promise.resolve(fakeResults);
+        },
+        [],
+        {
           onSuccess: () => onSuccess(),
           onError: () => onError(),
-        }),
-      {
-        initialProps: { ...props },
-      }
+        }
+      )
     );
 
+    expect(result.current.loading).toBe(true);
+
     await waitForNextUpdate();
 
     expect(result.current.result).toEqual(fakeResults);
@@ -84,23 +54,23 @@ describe('useAync', () => {
   });
 
   it('should set error detail for unsuccessful request', async () => {
-    fetch.mockReject(new Error('something went wrong'));
-
     const onSuccess = jest.fn();
     const onError = jest.fn();
 
     const { result, waitForNextUpdate } = renderHook<
       StarwarsHeroArgs,
       UseAsyncReturn<StarwarsHero[]>
-    >(
-      p =>
-        useAsync<StarwarsHero[], any>(p.asyncFunction, [], {
+    >(() =>
+      useAsync<StarwarsHero[], any>(
+        async () => {
+          return Promise.reject(new Error('something went wrong'));
+        },
+        [],
+        {
           onSuccess: () => onSuccess(),
           onError: () => onError(),
-        }),
-      {
-        initialProps: { ...props },
-      }
+        }
+      )
     );
 
     await waitForNextUpdate();

test/useAsync.test.ts

@@ -2182,14 +2182,6 @@ [email protected]:
     cross-spawn "^6.0.5"
     is-windows "^1.0.0"
 
-cross-fetch@^2.2.2:
-  version "2.2.3"
-  resolved "https://registry.npmjs.org/cross-fetch/-/cross-fetch-2.2.3.tgz#e8a0b3c54598136e037f8650f8e823ccdfac198e"
-  integrity sha512-PrWWNH3yL2NYIb/7WF/5vFG3DCQiXDOVf8k3ijatbrtnwNuhMWLC7YF7uqf53tbTFDzHIUD8oITw4Bxt8ST3Nw==
-  dependencies:
-    node-fetch "2.1.2"
-    whatwg-fetch "2.0.4"
-
 cross-spawn@^5.0.1:
   version "5.1.0"
   resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-5.1.0.tgz#e8bd0efee58fcff6f8f94510a0a554bbfa235449"
@@ -3595,14 +3587,6 @@ jest-environment-node@^24.8.0:
     jest-mock "^24.8.0"
     jest-util "^24.8.0"
 
-jest-fetch-mock@^2.1.2:
-  version "2.1.2"
-  resolved "https://registry.npmjs.org/jest-fetch-mock/-/jest-fetch-mock-2.1.2.tgz#1260b347918e3931c4ec743ceaf60433da661bd0"
-  integrity sha512-tcSR4Lh2bWLe1+0w/IwvNxeDocMI/6yIA2bijZ0fyWxC4kQ18lckQ1n7Yd40NKuisGmcGBRFPandRXrW/ti/Bw==
-  dependencies:
-    cross-fetch "^2.2.2"
-    promise-polyfill "^7.1.1"
-
 jest-get-type@^22.1.0:
   version "22.4.3"
   resolved "https://registry.yarnpkg.com/jest-get-type/-/jest-get-type-22.4.3.tgz#e3a8504d8479342dd4420236b322869f18900ce4"
@@ -4452,11 +4436,6 @@ nice-try@^1.0.4:
   resolved "https://registry.yarnpkg.com/nice-try/-/nice-try-1.0.5.tgz#a3378a7696ce7d223e88fc9b764bd7ef1089e366"
   integrity sha512-1nh45deeb5olNY7eX82BkPO7SSxR5SSYJiPTrTdFUVYwAl8CKMA5N9PjTYkHiRjisVcxcQ1HXdLhx2qxxJzLNQ==
 
-[email protected]:
-  version "2.1.2"
-  resolved "https://registry.npmjs.org/node-fetch/-/node-fetch-2.1.2.tgz#ab884e8e7e57e38a944753cec706f788d1768bb5"
-  integrity sha1-q4hOjn5X44qUR1POxwb3iNF2i7U=
-
 node-int64@^0.4.0:
   version "0.4.0"
   resolved "https://registry.yarnpkg.com/node-int64/-/node-int64-0.4.0.tgz#87a9065cdb355d3182d8f94ce11188b825c68a3b"
@@ -5024,11 +5003,6 @@ promise-inflight@^1.0.1:
   resolved "https://registry.yarnpkg.com/promise-inflight/-/promise-inflight-1.0.1.tgz#98472870bf228132fcbdd868129bad12c3c029e3"
   integrity sha1-mEcocL8igTL8vdhoEputEsPAKeM=
 
-promise-polyfill@^7.1.1:
-  version "7.1.2"
-  resolved "https://registry.npmjs.org/promise-polyfill/-/promise-polyfill-7.1.2.tgz#ab05301d8c28536301622d69227632269a70ca3b"
-  integrity sha512-FuEc12/eKqqoRYIGBrUptCBRhobL19PS2U31vMNTfyck1FxPyMfgsXyW4Mav85y/ZN1hop3hOwRlUDok23oYfQ==
-
 prompts@^2.0.1:
   version "2.0.4"
   resolved "https://registry.yarnpkg.com/prompts/-/prompts-2.0.4.tgz#179f9d4db3128b9933aa35f93a800d8fce76a682"
@@ -6510,11 +6484,6 @@ whatwg-encoding@^1.0.1, whatwg-encoding@^1.0.3:
   dependencies:
     iconv-lite "0.4.24"
 
-[email protected]:
-  version "2.0.4"
-  resolved "https://registry.npmjs.org/whatwg-fetch/-/whatwg-fetch-2.0.4.tgz#dde6a5df315f9d39991aa17621853d720b85566f"
-  integrity sha512-dcQ1GWpOD/eEQ97k66aiEVpNnapVj90/+R+SXTPYGHpYBBypfKJEQjLrvMZ7YXbKm21gXd4NcuxUTjiv1YtLng==
-
 whatwg-mimetype@^2.1.0, whatwg-mimetype@^2.2.0:
   version "2.3.0"
   resolved "https://registry.yarnpkg.com/whatwg-mimetype/-/whatwg-mimetype-2.3.0.tgz#3d4b1e0312d2079879f826aff18dbeeca5960fbf"