Skip to content

Commit 7aa642e

Browse files
committed
Merge branch 'PMP-kernel' of github.com:sloriot/cgal into PMP-kernel
2 parents bb76754 + 3c51305 commit 7aa642e

File tree

5 files changed

+10
-11
lines changed

5 files changed

+10
-11
lines changed

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -486,8 +486,8 @@ Mesh kernel: From left to right: (i) The input mesh; (ii) The kernel of the inpu
486486

487487

488488
As illustrated on \cgalFigureRef{coref_kernel_figure}, the kernel of a mesh is defined as the set of inside points from which the entire surface of the mesh is visible. More formally, a point belongs to the kernel if, for every point on the mesh, the segment connecting them lies entirely inside the mesh. Equivalently, the kernel is the intersection of the half-spaces induced by all faces of the mesh.
489-
The functions `CGAL::Polygon_mesh_processing::kernel()`, `CGAL::Polygon_mesh_processing::kernel_point()` and `CGAL::Polygon_mesh_processing::is_kernel_empty()` outputs respectively the full kernel, a single point inside it or
490-
simply whether the kernel exists.
489+
The functions `CGAL::Polygon_mesh_processing::kernel()`, `CGAL::Polygon_mesh_processing::kernel_point()` and `CGAL::Polygon_mesh_processing::is_kernel_empty()` output the full kernel, a single point inside it or
490+
a Boolean indicating whether the kernel exists or not, respectively.
491491

492492
\subsection coref_ex_subsec Examples
493493

@@ -1492,7 +1492,7 @@ preceding work. <a href="https://www.creatis.insa-lyon.fr/~valette/public/projec
14921492
used as a reference during the project.
14931493
The `apply_iterative_snap_rounding` option for autorefinement was implemented in 2025, by Léo Valque, based on his work with Sylvain Lazard \cgalCite{lazard:hal-04907149}.
14941494

1495-
The kernel functions and the convex specialization of `CGAL::Polygon_mesh_processing::clip()` and `CGAL::Polygon_mesh_processing::refine_with_plane()` was implemented in 2025, by Léo Valque, based on the work of Nehring-Wirxel et al. \cgalCite{nehring2025meshkernel}.
1495+
The kernel functions and the convex specialization of `CGAL::Polygon_mesh_processing::clip()` and `CGAL::Polygon_mesh_processing::refine_with_plane()` were implemented in 2025, by Léo Valque, based on the work of Nehring-Wirxel et al. \cgalCite{nehring2025meshkernel}.
14961496

14971497
*/
14981498
} /* namespace CGAL */

Polygon_mesh_processing/examples/Polygon_mesh_processing/mesh_kernel_example.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ int main(int argc, char** argv)
3030
std::cout << "Output containing " << vertices(kernel).size() << " vertices wrote in " << oname << std::endl;
3131

3232
std::ofstream("kernel.off") << kernel;
33-
}
33+
}

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/Three_point_cut_plane_traits.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ namespace Polygon_mesh_processing {
2525
\ingroup PMP_corefinement_grp
2626
2727
The class `Three_point_cut_plane_traits<Kernel>` is a model of the
28-
TODO concept. This traits class represents planes by three defining points and supports efficient point–plane orientation and plane–line intersection operations.
28+
TODO concept. In this traits class, a plane is represented by a triple of non-collinear points.
2929
3030
TODO documented or remains internal?
3131
@@ -117,4 +117,4 @@ struct Three_point_cut_plane_traits
117117

118118
} } // end of CGAL::Polygon_mesh_processing
119119

120-
#endif // CGAL_THREE_POINT_CUT_PLANE_TRAITS_H
120+
#endif // CGAL_THREE_POINT_CUT_PLANE_TRAITS_H

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/clip_convex.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace internal{
2727

2828
/**
2929
* Given a convex mesh and a plane, return an halfedge crossing the plane from a vertex on positive side to a vertex on the plane or the negative side.
30-
* Return a null halfedge if the mesh and the plane does not intersect.
30+
* Return a null halfedge if the mesh and the plane do not intersect.
3131
*/
3232
template <class PolygonMesh, class NamedParameters = parameters::Default_named_parameters>
3333
typename boost::graph_traits<PolygonMesh>::halfedge_descriptor

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/kernel.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,7 @@ kernel(const PolygonMesh& pm,
230230
*
231231
* The kernel is obtained by iteratively computing the intersection of the half-spaces defined by the faces of the mesh.
232232
*
233-
* The kernel may be degenerate. If the kernel has dimension 2, the output mesh consists of a single face. If the kernel has dimension 0 or 1,
234-
* the output mesh contains one or two isolate vertices, respectively.
233+
* The kernel may be degenerate. If the dimension of the kernel is 2, the output mesh consists of a single face. If the dimension of the kernel is 1, the output mesh contains only two isolated vertices. If the dimension of the kernel is 0, the output mesh contains only a single isolated vertex.
235234
*
236235
* @tparam PolygonMesh a model of `MutableFaceGraph`, `HalfedgeListGraph` and `FaceListGraph`.
237236
* An internal property map for `CGAL::vertex_point_t` must be available.
@@ -265,7 +264,7 @@ kernel(const PolygonMesh& pm,
265264
* \cgalParamNBegin{random_seed}
266265
* \cgalParamDescription{The seed use by the shuffle option}
267266
* \cgalParamType{unsigned int}
268-
* \cgalParamDefault{The seed of std::random_device()}
267+
* \cgalParamDefault{The seed of `std::random_device()`}
269268
* \cgalParamNEnd
270269
*
271270
* \cgalParamNBegin{starting_cube}
@@ -487,4 +486,4 @@ kernel_point(const PolygonMesh& pm,
487486

488487
} } // end of CGAL::Polygon_mesh_processing
489488

490-
#endif // CGAL_POLYGON_MESH_PROCESSING_KERNEL_H
489+
#endif // CGAL_POLYGON_MESH_PROCESSING_KERNEL_H

0 commit comments

Comments
 (0)